Bug 130860 - Check the remembered set bit faster
Summary: Check the remembered set bit faster
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-27 14:33 PDT by Mark Hahnenberg
Modified: 2014-03-27 15:34 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.43 KB, patch)
2014-03-27 14:42 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-03-27 14:33:54 PDT 
Currently we look up the remembered set bit in the MarkedBlock in C++ code, but that bit is also stored in the object. We should look it up there whenever possible.
Comment 1 Mark Hahnenberg 2014-03-27 14:42:09 PDT 
Created attachment 227983 [details]
Patch
Comment 2 Mark Hahnenberg 2014-03-27 14:44:16 PDT 
(In reply to comment #1)
> Created an attachment (id=227983) [details]
> Patch

This appears to be performance neutral on the benchmarks we track.
Comment 3 WebKit Commit Bot 2014-03-27 15:34:49 PDT 
Comment on attachment 227983 [details]
Patch

Clearing flags on attachment: 227983

Committed r166375: <http://trac.webkit.org/changeset/166375>
Comment 4 WebKit Commit Bot 2014-03-27 15:34:51 PDT 
All reviewed patches have been landed.  Closing bug.