Bug 130852 - Confirm composition in resignFirstResponder, don't cancel it
Summary: Confirm composition in resignFirstResponder, don't cancel it
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Reported: 2014-03-27 12:14 PDT by Alexey Proskuryakov
Modified: 2014-03-27 17:36 PDT (History)
5 users (show)

See Also:

proposed patch (1.24 KB, patch)
2014-03-27 12:16 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-03-27 12:14:45 PDT
We currently have code in -[WKView resignFirstResponder] that cancels the current composition. There are some problems with it:

1. It's a sync IPC call, which I want to eliminate.

2. It doesn't actually work most of the time, because editorState tracking is broken, and we often think that there is no composition even when there is one.

3. Modern AppKit behavior appears to be that it confirms a composition when switching between text views within a window. Or maybe it's flaky too, but one way or another, confirming seems like a reasonable behavior.
Comment 1 Alexey Proskuryakov 2014-03-27 12:16:26 PDT
Created attachment 227962 [details]
proposed patch

The same probably makes sense for old code path too, but I don't want to touch it unless absolutely necessary.
Comment 2 WebKit Commit Bot 2014-03-27 17:36:41 PDT
Comment on attachment 227962 [details]
proposed patch

Clearing flags on attachment: 227962

Committed r166388: <http://trac.webkit.org/changeset/166388>
Comment 3 WebKit Commit Bot 2014-03-27 17:36:44 PDT
All reviewed patches have been landed.  Closing bug.