Bug 130845 - Clean up questionable style in ScriptExecutable::prepareForExecutionImpl
Summary: Clean up questionable style in ScriptExecutable::prepareForExecutionImpl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-27 10:07 PDT by Mark Hahnenberg
Modified: 2014-03-27 12:19 PDT (History)
1 user (show)

See Also:

Attachments
patch (2.25 KB, patch)
2014-03-27 10:12 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
patch (2.48 KB, patch)
2014-03-27 10:25 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-03-27 10:07:59 PDT 
There was a hack added to make sure C Loop LLInt worked which included overriding the global Options::useLLInt setting, which makes no sense to do here. We should factor all of the crazy ifdefs into a separate shouldUseLLInt helper function and we should get rid of the global override.
Comment 1 Mark Hahnenberg 2014-03-27 10:12:53 PDT 
Created attachment 227954 [details]
patch
Comment 2 Mark Hahnenberg 2014-03-27 10:25:11 PDT 
Created attachment 227955 [details]
patch
Comment 3 WebKit Commit Bot 2014-03-27 12:19:55 PDT 
Comment on attachment 227955 [details]
patch

Clearing flags on attachment: 227955

Committed r166366: <http://trac.webkit.org/changeset/166366>
Comment 4 WebKit Commit Bot 2014-03-27 12:19:57 PDT 
All reviewed patches have been landed.  Closing bug.