Bug 130835 - AX: Returns const reference to static string.
Summary: AX: Returns const reference to static string.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Krzysztof Czech
Keywords: InRadar
Depends on:
Reported: 2014-03-27 06:17 PDT by Krzysztof Czech
Modified: 2014-03-27 08:19 PDT (History)
15 users (show)

See Also:

patch (3.18 KB, patch)
2014-03-27 06:24 PDT, Krzysztof Czech
mario: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Czech 2014-03-27 06:17:16 PDT
Avoiding unnecessary copies by returning const reference to static string.
Comment 1 Radar WebKit Bug Importer 2014-03-27 06:17:39 PDT
Comment 2 Krzysztof Czech 2014-03-27 06:24:50 PDT
Created attachment 227942 [details]
Comment 3 WebKit Commit Bot 2014-03-27 08:05:31 PDT
Comment on attachment 227942 [details]

Rejecting attachment 227942 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 227942, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/4872726934192128
Comment 4 Krzysztof Czech 2014-03-27 08:19:44 PDT
Committed r166358: <http://trac.webkit.org/changeset/166358>