Bug 130827 - Web Inspector: AXI: expose selectedChildNodeIds of list boxes, tree controls, etc., and reconcile UI with childNodeIds
Summary: Web Inspector: AXI: expose selectedChildNodeIds of list boxes, tree controls,...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Normal
Assignee: James Craig
Keywords: InRadar
Depends on:
Reported: 2014-03-27 01:54 PDT by James Craig
Modified: 2014-03-27 23:01 PDT (History)
5 users (show)

See Also:

patch (17.38 KB, patch)
2014-03-27 19:48 PDT, James Craig
timothy: review+
Details | Formatted Diff | Diff
patch with review feedback (16.03 KB, patch)
2014-03-27 22:21 PDT, James Craig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Craig 2014-03-27 01:54:14 PDT
Web Inspector: AXI: expose selected children of list boxes, tree controls, etc.
Comment 1 Radar WebKit Bug Importer 2014-03-27 01:54:29 PDT
Comment 2 James Craig 2014-03-27 19:48:29 PDT
Created attachment 228018 [details]
Comment 3 Timothy Hatcher 2014-03-27 20:49:37 PDT
Comment on attachment 228018 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=228018&action=review

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1561
> +                for (const auto& selectedChildObject : selectedChildren) {

No need for const, IIRC.

> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:393
> +                    this._accessibilityNodeChildrenRow.label = WebInspector.UIString("Child");                

I'd say Children is fine for the singular case too. Just not if a count is part if the label.

> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:414
> +                    this._accessibilityNodeSelectedChildrenRow.label = WebInspector.UIString("Selected Item");                

Hmm. I think this is fine though.
Comment 4 James Craig 2014-03-27 22:21:53 PDT
Created attachment 228024 [details]
patch with review feedback
Comment 5 WebKit Commit Bot 2014-03-27 23:01:06 PDT
Comment on attachment 228024 [details]
patch with review feedback

Clearing flags on attachment: 228024

Committed r166398: <http://trac.webkit.org/changeset/166398>
Comment 6 WebKit Commit Bot 2014-03-27 23:01:11 PDT
All reviewed patches have been landed.  Closing bug.