Bug 130817 - Add a _WKScriptWorld class
Summary: Add a _WKScriptWorld class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-26 20:48 PDT by Anders Carlsson
Modified: 2014-03-26 20:56 PDT (History)
0 users

See Also:


Attachments
Patch (10.27 KB, patch)
2014-03-26 20:50 PDT, Anders Carlsson
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-03-26 20:48:46 PDT
Add a _WKScriptWorld class
Comment 1 Anders Carlsson 2014-03-26 20:50:16 PDT
Created attachment 227915 [details]
Patch
Comment 2 mitz 2014-03-26 20:54:53 PDT
Comment on attachment 227915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227915&action=review

> Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.mm:79
> +- (BOOL)isEqual:(id)object
> +{
> +    if (![object isKindOfClass:[_WKScriptWorld class]])
> +        return NO;
> +
> +    return _worldID == ((_WKScriptWorld *)object)->_worldID;
> +}
> +
> +- (NSUInteger)hash
> +{
> +    return _worldID;
> +}

This seems premature.
Comment 3 Anders Carlsson 2014-03-26 20:56:16 PDT
Committed r166340: <http://trac.webkit.org/changeset/166340>