Bug 130763 - Add a new type of scrolling tree node for overflow scrolling
Summary: Add a new type of scrolling tree node for overflow scrolling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-25 19:44 PDT by Simon Fraser (smfr)
Modified: 2014-03-26 08:11 PDT (History)
13 users (show)

See Also:

Attachments
Patch (44.53 KB, patch)
2014-03-25 20:38 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-03-25 19:44:39 PDT 
Add a new type of scrolling tree node for overflow scrolling
Comment 1 Simon Fraser (smfr) 2014-03-25 20:38:13 PDT 
Created attachment 227827 [details]
Patch
Comment 2 Tim Horton 2014-03-25 22:20:40 PDT 
Comment on attachment 227827 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227827&action=review

> Source/WebCore/page/scrolling/ScrollingStateNode.h:155
> +    bool isFixedNode() const { return nodeType() == FixedNode; }

why do these use nodeType() instead of m_nodeType? (not that it matters)

> Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm:151
> +    case OverflowScrollingNode: // Not yet created on Mac.

Maybe this could be better documented with an ASSERT_NOT_REACHED() and return null? That will be easier to find when we implement scrolling-tree-overflow-scroll on Mac.
Comment 3 Simon Fraser (smfr) 2014-03-26 08:11:41 PDT 
http://trac.webkit.org/changeset/166293