Bug 130747 - PluginProcess rarely AppSleeps
Summary: PluginProcess rarely AppSleeps
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-25 15:24 PDT by Stephanie Lewis
Modified: 2014-03-28 18:20 PDT (History)
1 user (show)

See Also:

Attachments
patch (21.38 KB, patch)
2014-03-25 15:24 PDT, Stephanie Lewis 		slewis: review-
Details | Formatted Diff | Diff
real patch (2.95 KB, patch)
2014-03-27 14:18 PDT, Stephanie Lewis 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephanie Lewis 2014-03-25 15:24:35 PDT 
Created attachment 227808 [details]
patch

Synchronous messages between the WebProcess and the PluginProcess keep the PluginProcess awake even in the background.  Since we believe that AppSleep assertions are only necessary during user activity, drawing, or audio playing and those are all covered elsewhere don't take an assertion while conveying sync messages.
Comment 1 Stephanie Lewis 2014-03-27 14:04:12 PDT 
Comment on attachment 227808 [details]
patch

oops wrong patch
Comment 2 Stephanie Lewis 2014-03-27 14:18:40 PDT 
Created attachment 227979 [details]
real patch
Comment 3 Stephanie Lewis 2014-03-28 18:20:38 PDT 
http://trac.webkit.org/changeset/166444