WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
130731
[CSSRegions] Rename inNamedFlow flag to isNamedFlowContentNode flag
https://bugs.webkit.org/show_bug.cgi?id=130731
Summary
[CSSRegions] Rename inNamedFlow flag to isNamedFlowContentNode flag
Mihnea Ovidenie
Reported
2014-03-25 11:41:19 PDT
Currently, the inNamedFlow flag in Node class actually tells is a node is a content node, one that has a style with flow-into. Since it is used only for those nodes and not propagated through hierarchy, i want to renamed it to a more meaningful name.
Attachments
Patch
(8.19 KB, patch)
2014-03-25 11:46 PDT
,
Mihnea Ovidenie
no flags
Details
Formatted Diff
Diff
Patch for landing
(8.75 KB, patch)
2014-03-27 02:07 PDT
,
Mihnea Ovidenie
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Mihnea Ovidenie
Comment 1
2014-03-25 11:46:34 PDT
Created
attachment 227777
[details]
Patch
Andrei Bucur
Comment 2
2014-03-25 12:21:24 PDT
Comment on
attachment 227777
[details]
Patch r=me
WebKit Commit Bot
Comment 3
2014-03-27 01:09:55 PDT
Comment on
attachment 227777
[details]
Patch Rejecting
attachment 227777
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 227777, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: t 497 (offset 13 lines). Hunk #3 succeeded at 518 (offset 13 lines). Hunk #4 succeeded at 634 (offset 13 lines). patching file Source/WebCore/style/StyleResolveTree.cpp Hunk #1 FAILED at 422. Hunk #2 succeeded at 723 with fuzz 2 (offset 59 lines). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/style/StyleResolveTree.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Andrei Bucur']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output:
http://webkit-queues.appspot.com/results/4665520531963904
Mihnea Ovidenie
Comment 4
2014-03-27 02:07:46 PDT
Created
attachment 227935
[details]
Patch for landing
WebKit Commit Bot
Comment 5
2014-03-27 02:45:57 PDT
Comment on
attachment 227935
[details]
Patch for landing Clearing flags on attachment: 227935 Committed
r166354
: <
http://trac.webkit.org/changeset/166354
>
WebKit Commit Bot
Comment 6
2014-03-27 02:46:01 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug