Bug 130730 - Avoid duplicate size checks when creating empty image
Summary: Avoid duplicate size checks when creating empty image
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-25 11:12 PDT by Brent Fulgham
Modified: 2014-03-26 10:02 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.62 KB, patch)
2014-03-25 11:19 PDT, Brent Fulgham 		dino: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-03-25 11:12:24 PDT 
Size-checking logic in CanvasRenderingContext2D.cpp double-checks the size of the buffer, since the call to ImageData::create checks the size and returns nullptr on failure.

No need to do this calculation twice.

Merge from Blink:
    https://codereview.chromium.org/190633011
Comment 1 Brent Fulgham 2014-03-25 11:19:04 PDT 
Created attachment 227772 [details]
Patch
Comment 2 Dean Jackson 2014-03-25 14:22:12 PDT 
Comment on attachment 227772 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227772&action=review

> Source/WebCore/ChangeLog:19
> +2014-03-21  Brent Fulgham  <bfulgham@apple.com>
> +
> +        [iOS] Pass additional options to AVFoudnation during playback.
> +        https://bugs.webkit.org/show_bug.cgi?id=130624
> +

oops
Comment 3 WebKit Commit Bot 2014-03-26 09:47:16 PDT 
Comment on attachment 227772 [details]
Patch

Rejecting attachment 227772 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 227772, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/5560090815889408
Comment 4 Brent Fulgham 2014-03-26 10:02:46 PDT 
Committed r166300: <http://trac.webkit.org/changeset/166300>