Bug 130729 - [iOS] Playing video does not disable display sleep.
Summary: [iOS] Playing video does not disable display sleep.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-25 10:40 PDT by Jer Noble
Modified: 2014-03-25 13:26 PDT (History)
10 users (show)

See Also:

Attachments
Patch (10.99 KB, patch)
2014-03-25 10:46 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (13.00 KB, patch)
2014-03-25 10:54 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (25.07 KB, patch)
2014-03-25 11:27 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-03-25 10:40:05 PDT 
[iOS] Playing video does not disable display sleep.
Comment 1 Jer Noble 2014-03-25 10:46:46 PDT 
Created attachment 227766 [details]
Patch
Comment 2 Jer Noble 2014-03-25 10:54:06 PDT 
Created attachment 227767 [details]
Patch
Comment 3 Jer Noble 2014-03-25 11:27:13 PDT 
Created attachment 227773 [details]
Patch
Comment 4 Eric Carlson 2014-03-25 11:42:27 PDT 
Comment on attachment 227773 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227773&action=review

> Source/WebCore/platform/DisplaySleepDisabler.h:33
> +    static std::unique_ptr<DisplaySleepDisabler> create(const char* reason);

Nit: "reason" isn't necessary.

> Source/WebCore/platform/cocoa/DisplaySleepDisablerCocoa.hSource/WebCore/platform/mac/DisplaySleepDisabler.h:40
> +    DisplaySleepDisablerCocoa(const char* reason);

Ditto.
Comment 5 Jer Noble 2014-03-25 13:26:19 PDT 
Committed r166247: <http://trac.webkit.org/changeset/166247>