Bug 130725 - Web Inspector: AXI: support for live regions
Summary: Web Inspector: AXI: support for live regions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Normal
Assignee: James Craig
URL:
Keywords: InRadar
Depends on:
Blocks: 130918 130826 130913
  Show dependency treegraph
 
Reported: 2014-03-25 10:17 PDT by James Craig
Modified: 2014-03-28 22:34 PDT (History)
5 users (show)

See Also:


Attachments
patch (33.49 KB, patch)
2014-03-28 20:34 PDT, James Craig
timothy: review+
Details | Formatted Diff | Diff
patch with review feedback (34.10 KB, patch)
2014-03-28 21:23 PDT, James Craig
no flags Details | Formatted Diff | Diff
patch with review feedback (and test expectation update) (34.10 KB, patch)
2014-03-28 21:28 PDT, James Craig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Craig 2014-03-25 10:17:45 PDT
# Live Region Attrs (only when a live region)
- live (assertive, polite, off)
- relevance (additions, removals, etc)
- atomic

Especially useful b/c some roles (status, log, alert) get aria-live values by default. @aria-atomic and @aria-relevant is not always apparent on the current node either, if there is some depth to the live region.
Comment 1 Radar WebKit Bug Importer 2014-03-25 10:18:08 PDT
<rdar://problem/16420300>
Comment 2 James Craig 2014-03-25 11:52:49 PDT
AccessibilityObject::supportsARIALiveRegion()
AccessibilityObject::isInsideARIALiveRegion()
Comment 3 James Craig 2014-03-27 20:00:10 PDT
AccessibilityObject.h

    bool supportsARIALiveRegion() const;
    bool isInsideARIALiveRegion() const;
    virtual const AtomicString& ariaLiveRegionStatus() const { return nullAtom; }
    virtual const AtomicString& ariaLiveRegionRelevant() const { return nullAtom; }
    virtual bool ariaLiveRegionAtomic() const { return false; }
    virtual bool ariaLiveRegionBusy() const { return false; }
Comment 4 James Craig 2014-03-28 17:16:07 PDT
Done with most of this except:

Bug 130913: Web Inspector: AXI: expose aria-relevant
Bug 130918: Web Inspector: AXI: expose if current node is inside an ancestor live region
Comment 5 James Craig 2014-03-28 20:34:31 PDT
Created attachment 228103 [details]
patch
Comment 6 Timothy Hatcher 2014-03-28 20:50:24 PDT
Comment on attachment 228103 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228103&action=review

> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:366
> +                if (liveRegionStatusToken === DOMAgent.AccessibilityPropertiesLiveRegionStatus.Assertive)

This could be a switch with cases.

> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:370
> +                if (liveRegionStatus !== "" && accessibilityProperties.liveRegionAtomic === true) {

No need for !== "".
Comment 7 James Craig 2014-03-28 21:23:50 PDT
Created attachment 228104 [details]
patch with review feedback
Comment 8 James Craig 2014-03-28 21:28:54 PDT
Created attachment 228105 [details]
patch with review feedback (and test expectation update)
Comment 9 WebKit Commit Bot 2014-03-28 22:34:00 PDT
Comment on attachment 228105 [details]
patch with review feedback (and test expectation update)

Clearing flags on attachment: 228105

Committed r166449: <http://trac.webkit.org/changeset/166449>
Comment 10 WebKit Commit Bot 2014-03-28 22:34:03 PDT
All reviewed patches have been landed.  Closing bug.