RESOLVED FIXED 130725
Web Inspector: AXI: support for live regions
https://bugs.webkit.org/show_bug.cgi?id=130725
Summary Web Inspector: AXI: support for live regions
James Craig
Reported 2014-03-25 10:17:45 PDT
# Live Region Attrs (only when a live region) - live (assertive, polite, off) - relevance (additions, removals, etc) - atomic Especially useful b/c some roles (status, log, alert) get aria-live values by default. @aria-atomic and @aria-relevant is not always apparent on the current node either, if there is some depth to the live region.
Attachments
patch (33.49 KB, patch)
2014-03-28 20:34 PDT, James Craig
timothy: review+
patch with review feedback (34.10 KB, patch)
2014-03-28 21:23 PDT, James Craig
no flags
patch with review feedback (and test expectation update) (34.10 KB, patch)
2014-03-28 21:28 PDT, James Craig
no flags
Radar WebKit Bug Importer
Comment 1 2014-03-25 10:18:08 PDT
James Craig
Comment 2 2014-03-25 11:52:49 PDT
AccessibilityObject::supportsARIALiveRegion() AccessibilityObject::isInsideARIALiveRegion()
James Craig
Comment 3 2014-03-27 20:00:10 PDT
AccessibilityObject.h bool supportsARIALiveRegion() const; bool isInsideARIALiveRegion() const; virtual const AtomicString& ariaLiveRegionStatus() const { return nullAtom; } virtual const AtomicString& ariaLiveRegionRelevant() const { return nullAtom; } virtual bool ariaLiveRegionAtomic() const { return false; } virtual bool ariaLiveRegionBusy() const { return false; }
James Craig
Comment 4 2014-03-28 17:16:07 PDT
Done with most of this except: Bug 130913: Web Inspector: AXI: expose aria-relevant Bug 130918: Web Inspector: AXI: expose if current node is inside an ancestor live region
James Craig
Comment 5 2014-03-28 20:34:31 PDT
Timothy Hatcher
Comment 6 2014-03-28 20:50:24 PDT
Comment on attachment 228103 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=228103&action=review > Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:366 > + if (liveRegionStatusToken === DOMAgent.AccessibilityPropertiesLiveRegionStatus.Assertive) This could be a switch with cases. > Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:370 > + if (liveRegionStatus !== "" && accessibilityProperties.liveRegionAtomic === true) { No need for !== "".
James Craig
Comment 7 2014-03-28 21:23:50 PDT
Created attachment 228104 [details] patch with review feedback
James Craig
Comment 8 2014-03-28 21:28:54 PDT
Created attachment 228105 [details] patch with review feedback (and test expectation update)
WebKit Commit Bot
Comment 9 2014-03-28 22:34:00 PDT
Comment on attachment 228105 [details] patch with review feedback (and test expectation update) Clearing flags on attachment: 228105 Committed r166449: <http://trac.webkit.org/changeset/166449>
WebKit Commit Bot
Comment 10 2014-03-28 22:34:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.