Bug 130712 - Web Inspector: AXI: add support for aria-activedescendant and reconcile UI/testing with parentNode
Summary: Web Inspector: AXI: add support for aria-activedescendant and reconcile UI/te...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: James Craig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-03-25 00:22 PDT by James Craig
Modified: 2014-03-25 20:04 PDT (History)
5 users (show)

See Also:

Attachments
patch (19.93 KB, patch)
2014-03-25 00:33 PDT, James Craig 		timothy: review+
Details | Formatted Diff | Diff
screen shot (279.35 KB, image/png)
2014-03-25 00:47 PDT, James Craig 		no flags Details
patch (20.13 KB, patch)
2014-03-25 18:44 PDT, James Craig 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Craig 2014-03-25 00:22:08 PDT 
Web Inspector: AXI: add support for aria-activedescendant and UI/testing with parentNode
Comment 1 Radar WebKit Bug Importer 2014-03-25 00:22:24 PDT 
<rdar://problem/16416603>
Comment 2 James Craig 2014-03-25 00:33:32 PDT 
Created attachment 227726 [details]
patch

Looking for a better/shorter name than "Active Descendant" especially since it doesn't have to be a descendant. Current patch is using the UI String "Focus Pointer" but I'm very open to suggestions if you think of something better.
Comment 3 James Craig 2014-03-25 00:47:49 PDT 
Created attachment 227727 [details]
screen shot

Attached to so UI. Inspector is focused on the Facebook search combo box. Focus pointer (active descendant) hovered in the sidebar so the overlay is on the selected search suggestion. 
(Note one site author error is visible. The "Owns" pointer is a div with no defined role, when combobox expects @aria-owns to point to the listbox.)
Comment 4 James Craig 2014-03-25 01:01:47 PDT 
s/Attached to so UI/Attached to show UI/
Comment 5 James Craig 2014-03-25 01:02:51 PDT 
Potential UI String alternatives to "Focus Pointer": Focus Point, Acting Focus, Focus Proxy, Proxy Focus, Pseudo-Focus, Focus Redirect.
Comment 6 James Craig 2014-03-25 01:03:59 PDT 
Acting Focus and Focus Proxy are my top choices atm.
Comment 7 Timothy Hatcher 2014-03-25 15:52:57 PDT 
Comment on attachment 227726 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227726&action=review

> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:61
> +        this._accessibilityNodeActiveDescendantRow = new WebInspector.DetailsSectionSimpleRow(WebInspector.UIString("Focus Pointer"));

I think Active Descendant is fine, since it matches the ARIA wording.
Comment 8 James Craig 2014-03-25 18:44:27 PDT 
Created attachment 227822 [details]
patch

New patch uses "Shared Focus" to match the desktop terminology.
Comment 9 WebKit Commit Bot 2014-03-25 20:04:06 PDT 
Comment on attachment 227822 [details]
patch

Clearing flags on attachment: 227822

Committed r166279: <http://trac.webkit.org/changeset/166279>
Comment 10 WebKit Commit Bot 2014-03-25 20:04:10 PDT 
All reviewed patches have been landed.  Closing bug.