Bug 130700 - Enable WEB_REPLAY for PLATFORM(MAC)
Summary: Enable WEB_REPLAY for PLATFORM(MAC)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Major
Assignee: Brian Burg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-24 16:21 PDT by BJ Burg
Modified: 2014-04-06 10:29 PDT (History)
8 users (show)

See Also:

Attachments
wip - needs inspector UI toggle (8.75 KB, patch)
2014-04-04 19:35 PDT, Brian Burg 		no flags Details | Formatted Diff | Diff
the patch (17.87 KB, patch)
2014-04-05 23:12 PDT, Brian Burg 		timothy: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2014-03-24 16:21:19 PDT 
We would like to compile with this feature turned on for nightlies. Replay controls will be hidden behind a setting or key combination in the inspector UI until the temporary replay UI is replaced.
Comment 1 Brian Burg 2014-04-04 19:35:29 PDT 
Created attachment 228647 [details]
wip - needs inspector UI toggle
Comment 2 Timothy Hatcher 2014-04-04 20:36:06 PDT 
Comment on attachment 228647 [details]
wip - needs inspector UI toggle

Looking good so far.
Comment 3 Brian Burg 2014-04-05 23:12:44 PDT 
Created attachment 228694 [details]
the patch
Comment 4 Timothy Hatcher 2014-04-06 09:34:01 PDT 
Comment on attachment 228694 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228694&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js:401
> +            contextMenu.appendItem(WebInspector.UIString("Hide replay controls"), toggleReplayInterface);

Menu titles are Title Case.

> Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js:403
> +            contextMenu.appendItem(WebInspector.UIString("Show replay controls"), toggleReplayInterface);

Ditto.
Comment 5 Brian Burg 2014-04-06 10:28:44 PDT 
Committed r166851: <http://trac.webkit.org/changeset/166851>
Comment 6 Brian Burg 2014-04-06 10:29:38 PDT 
(In reply to comment #4)
> (From update of attachment 228694 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228694&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js:401
> > +            contextMenu.appendItem(WebInspector.UIString("Hide replay controls"), toggleReplayInterface);
> 
> Menu titles are Title Case.
> 
> > Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js:403
> > +            contextMenu.appendItem(WebInspector.UIString("Show replay controls"), toggleReplayInterface);
> 
> Ditto.

Fixed.