RESOLVED FIXED 130698
[CSS Shapes] Remove shape-inside support 
https://bugs.webkit.org/show_bug.cgi?id=130698
Summary [CSS Shapes] Remove shape-inside support
Zoltan Horvath
Reported 2014-03-24 15:28:19 PDT
CSS Shapes Level 1 (CR) only contains shape-outside. We are focusing our efforts on finalizing the implementation of shape-outside, it's worth to remove shape-inside code at this point for now. A list of reasons for the removal: - Shape-inside is only part of Shapes Level 2, which needs to be improved on some topics. - Shape-inside is lack of new shapes support (e.g. inset). - Deprecated shapes (r165472) are removed from the code (e.g. rectangle), which affects shape-inside. - The current shape-inside code spreads across the layout code. - The current shape-inside implementation is experimental in some areas, and the partially implemented code can have security implications. - Removal of shape-inside opens possibilities for code complexity and performance optimizations for shape-outside. (e.g. simpler geometry code) If there is no objections, I'll remove the code for now, so we can start working on the mentioned optimizations. I'll also close the bugs in bugzilla which are affected by the change.
Attachments
Patch (561.17 KB, patch)
2014-03-24 15:38 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
Patch (563.75 KB, patch)
2014-03-24 16:34 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
Patch (563.91 KB, patch)
2014-03-24 16:50 PDT, Zoltan Horvath 		hyatt: review+
DetailsFormatted DiffDiff
Patch (563.29 KB, patch)
2014-03-26 08:46 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
Patch for landing (563.27 KB, patch)
2014-03-26 10:40 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2014-03-24 15:38:05 PDT
Created attachment 227695 [details] Patch
Zoltan Horvath
Comment 2 2014-03-24 16:34:13 PDT
Created attachment 227702 [details] Patch
Zoltan Horvath
Comment 3 2014-03-24 16:50:26 PDT
Created attachment 227705 [details] Patch
Zoltan Horvath
Comment 4 2014-03-24 18:03:29 PDT
Once it is reviewed, I'll send out a mail to webkit-dev and wait 24hrs before landing.
Dave Hyatt
Comment 5 2014-03-25 10:19:57 PDT
Comment on attachment 227705 [details] Patch r=me
Zoltan Horvath
Comment 6 2014-03-26 08:46:27 PDT
Created attachment 227850 [details] Patch
Zoltan Horvath
Comment 7 2014-03-26 10:40:30 PDT
Created attachment 227863 [details] Patch for landing
WebKit Commit Bot
Comment 8 2014-03-26 11:20:45 PDT
Comment on attachment 227863 [details] Patch for landing Clearing flags on attachment: 227863 Committed r166301: <http://trac.webkit.org/changeset/166301>
WebKit Commit Bot
Comment 9 2014-03-26 11:20:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.