Bug 130698 - [CSS Shapes] Remove shape-inside support
Summary: [CSS Shapes] Remove shape-inside support
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
Depends on: 131641
Blocks: 89256 127982 130740 130790
  Show dependency treegraph
Reported: 2014-03-24 15:28 PDT by Zoltan Horvath
Modified: 2014-04-14 15:34 PDT (History)
24 users (show)

See Also:

Patch (561.17 KB, patch)
2014-03-24 15:38 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff
Patch (563.75 KB, patch)
2014-03-24 16:34 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff
Patch (563.91 KB, patch)
2014-03-24 16:50 PDT, Zoltan Horvath
hyatt: review+
Details | Formatted Diff | Diff
Patch (563.29 KB, patch)
2014-03-26 08:46 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff
Patch for landing (563.27 KB, patch)
2014-03-26 10:40 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2014-03-24 15:28:19 PDT
CSS Shapes Level 1 (CR) only contains shape-outside. We are focusing our efforts on finalizing the implementation of shape-outside, it's worth to remove shape-inside code at this point for now.

A list of reasons for the removal:
- Shape-inside is only part of Shapes Level 2, which needs to be improved on some topics.
- Shape-inside is lack of new shapes support (e.g. inset).
- Deprecated shapes (r165472) are removed from the code (e.g. rectangle), which affects shape-inside. 
- The current shape-inside code spreads across the layout code.
- The current shape-inside implementation is experimental in some areas, and the partially implemented code can have security implications.
- Removal of shape-inside opens possibilities for code complexity and performance optimizations for shape-outside. (e.g. simpler geometry code)

If there is no objections, I'll remove the code for now, so we can start working on the mentioned optimizations. I'll also close the bugs in bugzilla which are affected by the change.
Comment 1 Zoltan Horvath 2014-03-24 15:38:05 PDT
Created attachment 227695 [details]
Comment 2 Zoltan Horvath 2014-03-24 16:34:13 PDT
Created attachment 227702 [details]
Comment 3 Zoltan Horvath 2014-03-24 16:50:26 PDT
Created attachment 227705 [details]
Comment 4 Zoltan Horvath 2014-03-24 18:03:29 PDT
Once it is reviewed, I'll send out a mail to webkit-dev and wait 24hrs before landing.
Comment 5 Dave Hyatt 2014-03-25 10:19:57 PDT
Comment on attachment 227705 [details]

Comment 6 Zoltan Horvath 2014-03-26 08:46:27 PDT
Created attachment 227850 [details]
Comment 7 Zoltan Horvath 2014-03-26 10:40:30 PDT
Created attachment 227863 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2014-03-26 11:20:45 PDT
Comment on attachment 227863 [details]
Patch for landing

Clearing flags on attachment: 227863

Committed r166301: <http://trac.webkit.org/changeset/166301>
Comment 9 WebKit Commit Bot 2014-03-26 11:20:54 PDT
All reviewed patches have been landed.  Closing bug.