Bug 130697 - REGRESSION (r165872): Double-applying device scale to snapshots
Summary: REGRESSION (r165872): Double-applying device scale to snapshots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-03-24 15:20 PDT by Tim Horton
Modified: 2014-03-24 16:14 PDT (History)
3 users (show)

See Also:

Attachments
patch (3.73 KB, patch)
2014-03-24 15:43 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-03-24 15:20:49 PDT 
I made a mistake in r165872 that caused us to apply the device scale twice when snapshotting via scaledSnapshotWithOptions.

<rdar://problem/16396629>
Comment 1 Tim Horton 2014-03-24 15:43:21 PDT 
Created attachment 227697 [details]
patch

1) We need snapshotting tests desperately, there are too many combinations of options to not have some tests.
2) I need to test WKThumbnailView before landing this.
Comment 2 Tim Horton 2014-03-24 16:14:59 PDT 
http://trac.webkit.org/changeset/166203