Bug 130688 - Add support for thread/WorkQueue QoS
Summary: Add support for thread/WorkQueue QoS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-24 11:30 PDT by Gavin Barraclough
Modified: 2014-06-12 19:30 PDT (History)
11 users (show)

See Also:

Attachments
Fix (5.58 KB, patch)
2014-03-24 11:33 PDT, Gavin Barraclough 		kling: review+
Details | Formatted Diff | Diff
Fix (9.73 KB, patch)
2014-06-12 18:04 PDT, Gavin Barraclough 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2014-03-24 11:30:32 PDT 
.
Comment 1 Gavin Barraclough 2014-03-24 11:33:59 PDT 
Created attachment 227670 [details]
Fix
Comment 2 Andreas Kling 2014-03-24 12:03:37 PDT 
Comment on attachment 227670 [details]
Fix

r=me
Comment 3 Gavin Barraclough 2014-03-24 12:26:02 PDT 
Transmitting file data .......
Committed revision 166184.
Comment 4 Gavin Barraclough 2014-03-24 12:32:11 PDT 
Speculative EFL build fix in:

Transmitting file data ..
Committed revision 166185.
Comment 5 Gavin Barraclough 2014-06-12 18:03:31 PDT 
Previous fix rolled out.
Comment 6 Gavin Barraclough 2014-06-12 18:04:37 PDT 
Created attachment 233012 [details]
Fix
Comment 7 Anders Carlsson 2014-06-12 18:14:29 PDT 
Comment on attachment 233012 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=233012&action=review

> Source/WebKit2/Platform/mac/WorkQueueMac.cpp:48
> +static dispatch_qos_class_t platformQOS(WorkQueue::QOS qos)

I'd call this dispatchQOSClass instead.

> Source/WebKit2/Platform/mac/WorkQueueMac.cpp:60
> +    default:
> +        return QOS_CLASS_DEFAULT;

Please move this return out of the switch statement and add an ASSERT_NOT_REACHED() before it.
Comment 8 Simon Fraser (smfr) 2014-06-12 18:19:17 PDT 
Comment on attachment 233012 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=233012&action=review

> Source/WTF/wtf/Threading.cpp:91
> +#if (TARGET_OS_MAC && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000)
> +    pthread_set_qos_class_self_np(QOS_CLASS_USER_INTERACTIVE, 0);
> +#endif

Use HAVE_QOS_CLASSES

> Source/WebKit2/config.h:99
> +#ifndef HAVE_QOS_CLASSES
> +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
> +#define HAVE_QOS_CLASSES 1
> +#endif
> +#endif

Move to Platform.h
Comment 9 Gavin Barraclough 2014-06-12 19:30:44 PDT 
Fixed in r169926.