WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
130674
fix prepare-ChangeLog after
r166156
.
https://bugs.webkit.org/show_bug.cgi?id=130674
Summary
fix prepare-ChangeLog after r166156.
László Langó
Reported
2014-03-24 09:12:12 PDT
After
r166156
prepare-ChangeLog lists some functions as deleted, but they are not. See in context:
https://bugs.webkit.org/attachment.cgi?id=227641&action=review
Attachments
Patch
(4.26 KB, patch)
2014-03-24 09:19 PDT
,
László Langó
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
László Langó
Comment 1
2014-03-24 09:19:57 PDT
Created
attachment 227653
[details]
Patch
Darin Adler
Comment 2
2014-03-24 13:20:15 PDT
Comment on
attachment 227653
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=227653&action=review
> Tools/Scripts/prepare-ChangeLog:1977 > - $end = $3 || $1; > + if($4 gt "a") { > + $end = $3 || $1; > + }
Missing space before "(". But since this is perl you could write: $end = $3 || $1 if $4 ne "a"; I think “ne” would be better than “gt”.
WebKit Commit Bot
Comment 3
2014-03-24 13:51:45 PDT
Comment on
attachment 227653
[details]
Patch Clearing flags on attachment: 227653 Committed
r166189
: <
http://trac.webkit.org/changeset/166189
>
WebKit Commit Bot
Comment 4
2014-03-24 13:51:51 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug