Bug 130674 - fix prepare-ChangeLog after r166156.
Summary: fix prepare-ChangeLog after r166156.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: László Langó
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-24 09:12 PDT by László Langó
Modified: 2014-03-24 13:51 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.26 KB, patch)
2014-03-24 09:19 PDT, László Langó 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description László Langó 2014-03-24 09:12:12 PDT 
After r166156 prepare-ChangeLog lists some functions as deleted, but they are not. See in context: https://bugs.webkit.org/attachment.cgi?id=227641&action=review
Comment 1 László Langó 2014-03-24 09:19:57 PDT 
Created attachment 227653 [details]
Patch
Comment 2 Darin Adler 2014-03-24 13:20:15 PDT 
Comment on attachment 227653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227653&action=review

> Tools/Scripts/prepare-ChangeLog:1977
> -        $end = $3 || $1;
> +        if($4 gt "a") {
> +            $end = $3 || $1;
> +        }

Missing space before "(". But since this is perl you could write:

    $end = $3 || $1 if $4 ne "a";

I think “ne” would be better than “gt”.
Comment 3 WebKit Commit Bot 2014-03-24 13:51:45 PDT 
Comment on attachment 227653 [details]
Patch

Clearing flags on attachment: 227653

Committed r166189: <http://trac.webkit.org/changeset/166189>
Comment 4 WebKit Commit Bot 2014-03-24 13:51:51 PDT 
All reviewed patches have been landed.  Closing bug.