Bug 130669 - ENABLE(CSS_GRID_LAYOUT) guard for CSSGridLineNamesValue
Summary: ENABLE(CSS_GRID_LAYOUT) guard for CSSGridLineNamesValue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-24 08:11 PDT by Martin Hodovan
Modified: 2014-03-24 10:13 PDT (History)
9 users (show)

See Also:


Attachments
Proposed patch (2.35 KB, patch)
2014-03-24 08:19 PDT, Martin Hodovan
no flags Details | Formatted Diff | Diff
Proposed patch (2.11 KB, patch)
2014-03-24 09:02 PDT, Martin Hodovan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Hodovan 2014-03-24 08:11:28 PDT
https://trac.webkit.org/changeset/166157 added new files
related to CSS Grid Layout which should be guarded too:
- Source/WebCore/css/CSSGridLineNamesValue.cpp
- Source/WebCore/css/CSSGridLineNamesValue.h
Comment 1 Martin Hodovan 2014-03-24 08:19:08 PDT
Created attachment 227645 [details]
Proposed patch
Comment 2 Csaba Osztrogonác 2014-03-24 08:25:06 PDT
Comment on attachment 227645 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227645&action=review

> Source/WebCore/ChangeLog:9
> +        https://trac.webkit.org/changeset/166157 added new files
> +        related to CSS Grid Layout which should be guarded too:
> +        - Source/WebCore/css/CSSGridLineNamesValue.cpp
> +        - Source/WebCore/css/CSSGridLineNamesValue.h

There is no need for duplicating file names here and 
adding this long url for the original changeset.
Comment 3 Martin Hodovan 2014-03-24 09:02:38 PDT
Created attachment 227650 [details]
Proposed patch
Comment 4 Sergio Villar Senin 2014-03-24 09:42:27 PDT
Comment on attachment 227650 [details]
Proposed patch

Thanks!
Comment 5 WebKit Commit Bot 2014-03-24 10:13:33 PDT
Comment on attachment 227650 [details]
Proposed patch

Clearing flags on attachment: 227650

Committed r166176: <http://trac.webkit.org/changeset/166176>
Comment 6 WebKit Commit Bot 2014-03-24 10:13:38 PDT
All reviewed patches have been landed.  Closing bug.