WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
130669
ENABLE(CSS_GRID_LAYOUT) guard for CSSGridLineNamesValue
https://bugs.webkit.org/show_bug.cgi?id=130669
Summary
ENABLE(CSS_GRID_LAYOUT) guard for CSSGridLineNamesValue
Martin Hodovan
Reported
2014-03-24 08:11:28 PDT
https://trac.webkit.org/changeset/166157
added new files related to CSS Grid Layout which should be guarded too: - Source/WebCore/css/CSSGridLineNamesValue.cpp - Source/WebCore/css/CSSGridLineNamesValue.h
Attachments
Proposed patch
(2.35 KB, patch)
2014-03-24 08:19 PDT
,
Martin Hodovan
no flags
Details
Formatted Diff
Diff
Proposed patch
(2.11 KB, patch)
2014-03-24 09:02 PDT
,
Martin Hodovan
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Martin Hodovan
Comment 1
2014-03-24 08:19:08 PDT
Created
attachment 227645
[details]
Proposed patch
Csaba Osztrogonác
Comment 2
2014-03-24 08:25:06 PDT
Comment on
attachment 227645
[details]
Proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=227645&action=review
> Source/WebCore/ChangeLog:9 > +
https://trac.webkit.org/changeset/166157
added new files > + related to CSS Grid Layout which should be guarded too: > + - Source/WebCore/css/CSSGridLineNamesValue.cpp > + - Source/WebCore/css/CSSGridLineNamesValue.h
There is no need for duplicating file names here and adding this long url for the original changeset.
Martin Hodovan
Comment 3
2014-03-24 09:02:38 PDT
Created
attachment 227650
[details]
Proposed patch
Sergio Villar Senin
Comment 4
2014-03-24 09:42:27 PDT
Comment on
attachment 227650
[details]
Proposed patch Thanks!
WebKit Commit Bot
Comment 5
2014-03-24 10:13:33 PDT
Comment on
attachment 227650
[details]
Proposed patch Clearing flags on attachment: 227650 Committed
r166176
: <
http://trac.webkit.org/changeset/166176
>
WebKit Commit Bot
Comment 6
2014-03-24 10:13:38 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug