Bug 130665 – [GTK] [TextureMapper] Weird brightness with some videos with acceletared compositing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Xabier Rodríguez Calvar]

Created attachment 227639 [details]
Example of the problem (left: correct, right: wrong)

Visit http://people.igalia.com/xrcalvar/talks/20131022-GstConf-WebKit/index.html#4 with AC activated and deactivated.

When it deactivated the video is ok, when it isn't the video has 'an excess of brightness'.

[Xabier Rodríguez Calvar]

The pipeline is the same so there must be a problem when dealing with the texture.

[Xabier Rodríguez Calvar]

Created attachment 227874 [details]
Patch

[Martin Robinson]

Comment on attachment 227874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227874&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests needed, current set suffices.

They don't actually! You need to tell the truth here which is is that we do not yet have the ability to test accelerated composited contents on the bots.

> Source/WebCore/platform/graphics/texmap/TextureMapper.h:50
> +        None = 0x00,

None should probably be called NoFlag and you should use 0 here instead of 0x00.

[Xabier Rodríguez Calvar]

(In reply to comment #3)
> (From update of attachment 227874 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=227874&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests needed, current set suffices.
> 
> They don't actually! You need to tell the truth here which is is that we do not yet have the ability to test accelerated composited contents on the bots.

I should have been more verbose. The current test would perfectly suffice if we were able to activate accelerated composition in the bots.

> > Source/WebCore/platform/graphics/texmap/TextureMapper.h:50
> > +        None = 0x00,
> 
> None should probably be called NoFlag and you should use 0 here instead of 0x00.

Roger.

[Xabier Rodríguez Calvar]

Created attachment 228037 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 228037 [details]
Patch for landing

Rejecting attachment 228037 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 228037, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

[e-mail] found in /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/4775424450101248

[Xabier Rodríguez Calvar]

Created attachment 228039 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 228039 [details]
Patch for landing

Rejecting attachment 228039 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 228039, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

[e-mail] found in /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/5825698572795904

[Xabier Rodríguez Calvar]

Created attachment 228040 [details]
Patch for landing

[Xabier Rodríguez Calvar]

Comment on attachment 228040 [details]
Patch for landing

Let's avoid a land patch, go home. I can this when I have time to look at the bots.

[WebKit Commit Bot]

Comment on attachment 228040 [details]
Patch for landing

Clearing flags on attachment: 228040

Committed r166480: <http://trac.webkit.org/changeset/166480>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.