RESOLVED FIXED 130654
Simplify the HTMLConverter interface 
https://bugs.webkit.org/show_bug.cgi?id=130654
Summary Simplify the HTMLConverter interface
Sam Weinig
Reported 2014-03-23 13:09:19 PDT
Simplify the HTMLConverter interface
Attachments
Part 1 (4.31 KB, patch)
2014-03-23 13:12 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Part 2 (20.68 KB, patch)
2014-03-23 14:25 PDT, Sam Weinig 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2014-03-23 13:12:26 PDT
Created attachment 227615 [details] Part 1
mitz
Comment 2 2014-03-23 13:15:46 PDT
Comment on attachment 227615 [details] Part 1 View in context: https://bugs.webkit.org/attachment.cgi?id=227615&action=review > Source/WebCore/platform/mac/HTMLConverter.h:83 > ++ (NSAttributedString *)attributedStringFromRange:(WebCore::Range*)range; Why not make the argument a reference?
Sam Weinig
Comment 3 2014-03-23 13:17:01 PDT
(In reply to comment #2) > (From update of attachment 227615 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=227615&action=review > > > Source/WebCore/platform/mac/HTMLConverter.h:83 > > ++ (NSAttributedString *)attributedStringFromRange:(WebCore::Range*)range; > > Why not make the argument a reference? I'll see about doing that in a bit.
Sam Weinig
Comment 4 2014-03-23 13:18:16 PDT
Committed r166143: <http://trac.webkit.org/changeset/166143>
Sam Weinig
Comment 5 2014-03-23 14:25:05 PDT
Created attachment 227617 [details] Part 2
Darin Adler
Comment 6 2014-03-23 14:28:14 PDT
Comment on attachment 227617 [details] Part 2 View in context: https://bugs.webkit.org/attachment.cgi?id=227617&action=review > Source/WebKit/mac/WebView/WebHTMLView.mm:6667 > + attributedString = [[[NSAttributedString alloc] init] autorelease]; I think you can just write [NSAttributedString string] for this.
Sam Weinig
Comment 7 2014-03-23 14:41:40 PDT
Committed r166145: <http://trac.webkit.org/changeset/166145>
Note You need to log in before you can comment on or make changes to this bug.