Bug 130654 - Simplify the HTMLConverter interface
Summary: Simplify the HTMLConverter interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-23 13:09 PDT by Sam Weinig
Modified: 2014-03-23 14:41 PDT (History)
0 users

See Also:

Attachments
Part 1 (4.31 KB, patch)
2014-03-23 13:12 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Part 2 (20.68 KB, patch)
2014-03-23 14:25 PDT, Sam Weinig 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2014-03-23 13:09:19 PDT 
Simplify the HTMLConverter interface
Comment 1 Sam Weinig 2014-03-23 13:12:26 PDT 
Created attachment 227615 [details]
Part 1
Comment 2 mitz 2014-03-23 13:15:46 PDT 
Comment on attachment 227615 [details]
Part 1

View in context: https://bugs.webkit.org/attachment.cgi?id=227615&action=review

> Source/WebCore/platform/mac/HTMLConverter.h:83
> ++ (NSAttributedString *)attributedStringFromRange:(WebCore::Range*)range;

Why not make the argument a reference?
Comment 3 Sam Weinig 2014-03-23 13:17:01 PDT 
(In reply to comment #2)
> (From update of attachment 227615 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=227615&action=review
> 
> > Source/WebCore/platform/mac/HTMLConverter.h:83
> > ++ (NSAttributedString *)attributedStringFromRange:(WebCore::Range*)range;
> 
> Why not make the argument a reference?

I'll see about doing that in a bit.
Comment 4 Sam Weinig 2014-03-23 13:18:16 PDT 
Committed r166143: <http://trac.webkit.org/changeset/166143>
Comment 5 Sam Weinig 2014-03-23 14:25:05 PDT 
Created attachment 227617 [details]
Part 2
Comment 6 Darin Adler 2014-03-23 14:28:14 PDT 
Comment on attachment 227617 [details]
Part 2

View in context: https://bugs.webkit.org/attachment.cgi?id=227617&action=review

> Source/WebKit/mac/WebView/WebHTMLView.mm:6667
> +                attributedString = [[[NSAttributedString alloc] init] autorelease];

I think you can just write [NSAttributedString string] for this.
Comment 7 Sam Weinig 2014-03-23 14:41:40 PDT 
Committed r166145: <http://trac.webkit.org/changeset/166145>