Bug 130651 - WebKit::resistanceForDelta() truncates 'scaleDistance' to integer value using abs()
Summary: WebKit::resistanceForDelta() truncates 'scaleDistance' to integer value using...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
Depends on:
Reported: 2014-03-23 07:25 PDT by David Kilzer (:ddkilzer)
Modified: 2014-03-23 22:30 PDT (History)
3 users (show)

See Also:

Patch v1 (2.16 KB, patch)
2014-03-23 07:26 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2014-03-23 07:25:04 PDT
Compiling WebKit with trunk clang causes this warning:

Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:112:28: error: using integer absolute value function 'abs' when argument is of floating point type [-Werror,-Wabsolute-value]
    double scaleDistance = abs(limit - currentScale);
Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:112:28: note: use function 'fabs' instead
    double scaleDistance = abs(limit - currentScale);
1 error generated.
Comment 1 David Kilzer (:ddkilzer) 2014-03-23 07:26:41 PDT
Created attachment 227608 [details]
Patch v1
Comment 2 WebKit Commit Bot 2014-03-23 09:13:16 PDT
Comment on attachment 227608 [details]
Patch v1

Clearing flags on attachment: 227608

Committed r166140: <http://trac.webkit.org/changeset/166140>
Comment 3 WebKit Commit Bot 2014-03-23 09:13:19 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Tim Horton 2014-03-23 22:30:13 PDT
Yikes! Thanks for fixing.