130645 – Clean up #includes by geometry classes

RESOLVED FIXED 130645

Clean up #includes by geometry classes

https://bugs.webkit.org/show_bug.cgi?id=130645

Summary Clean up #includes by geometry classes

Simon Fraser (smfr)

Reported 2014-03-22 13:09:54 PDT

Clean up #includes by geometry classes

Attachments
Patch (26.85 KB, patch) 2014-03-22 13:11 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
For EWS (21.32 KB, patch) 2014-03-22 14:14 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
For EWS (27.61 KB, patch) 2014-03-22 16:55 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
For EWS (28.02 KB, patch) 2014-03-22 17:10 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
For EWS again (28.52 KB, patch) 2014-03-22 17:58 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Will it never end? (28.99 KB, patch) 2014-03-22 18:14 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Apparently not (29.46 KB, patch) 2014-03-22 18:29 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Sigh (29.89 KB, patch) 2014-03-22 18:39 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Trying again (30.93 KB, patch) 2014-03-22 19:07 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Yep (33.19 KB, patch) 2014-03-22 20:58 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
We love you EFL (33.76 KB, patch) 2014-03-22 22:31 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
We love you EFL even more (34.34 KB, patch) 2014-03-22 23:51 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Show Obsolete (11) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2014-03-22 13:11:59 PDT

Created attachment 227566 [details] Patch

Andreas Kling

Comment 2 2014-03-22 13:15:33 PDT

Comment on attachment 227566 [details] Patch Great! r=me if it builds :)

WebKit Commit Bot

Comment 3 2014-03-22 13:48:22 PDT

Comment on attachment 227566 [details] Patch Rejecting attachment 227566 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ang.1_0.compiler CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/AccessibilityMockObject.o accessibility/AccessibilityMockObject.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/AccessibilitySpinButton.o accessibility/AccessibilitySpinButton.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (7 failures) Full output: http://webkit-queues.appspot.com/results/6569124461281280

Simon Fraser (smfr)

Comment 4 2014-03-22 14:14:53 PDT

Created attachment 227571 [details] For EWS

Simon Fraser (smfr)

Comment 5 2014-03-22 16:55:26 PDT

Created attachment 227579 [details] For EWS

Simon Fraser (smfr)

Comment 6 2014-03-22 17:10:57 PDT

Created attachment 227582 [details] For EWS

Simon Fraser (smfr)

Comment 7 2014-03-22 17:58:27 PDT

Created attachment 227588 [details] For EWS again

Simon Fraser (smfr)

Comment 8 2014-03-22 18:14:42 PDT

Created attachment 227589 [details] Will it never end?

Simon Fraser (smfr)

Comment 9 2014-03-22 18:29:54 PDT

Created attachment 227591 [details] Apparently not

Simon Fraser (smfr)

Comment 10 2014-03-22 18:39:55 PDT

Created attachment 227593 [details] Sigh

Simon Fraser (smfr)

Comment 11 2014-03-22 19:07:57 PDT

Created attachment 227594 [details] Trying again

Simon Fraser (smfr)

Comment 12 2014-03-22 20:58:49 PDT

Created attachment 227597 [details] Yep

Simon Fraser (smfr)

Comment 13 2014-03-22 22:31:41 PDT

Created attachment 227603 [details] We love you EFL

Simon Fraser (smfr)

Comment 14 2014-03-22 23:51:36 PDT

Created attachment 227606 [details] We love you EFL even more

Andreas Kling

Comment 15 2014-03-23 01:05:18 PDT

Comment on attachment 227606 [details] We love you EFL even more Sending her off to landing.

WebKit Commit Bot

Comment 16 2014-03-23 01:36:40 PDT

Comment on attachment 227606 [details] We love you EFL even more Clearing flags on attachment: 227606 Committed r166138: <http://trac.webkit.org/changeset/166138>

WebKit Commit Bot

Comment 17 2014-03-23 01:36:48 PDT

All reviewed patches have been landed. Closing bug.

Simon Fraser (smfr)

Comment 18 2014-03-23 13:09:45 PDT

http://trac.webkit.org/changeset/166139 is what I get by doing this before coffee.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Simon Fraser (smfr)

Reported

2014-03-22 13:09 PDT

Modified

2014-03-23 13:09 PDT History

CC List

17 users Show

URL

Keywords

Depends on

Blocks