Bug 130644 - Call linking slow paths should be passed a CallLinkInfo* directly so that you can create a call IC without adding it to any CodeBlocks
Summary: Call linking slow paths should be passed a CallLinkInfo* directly so that you...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 130670
Blocks: 129589
  Show dependency tree / graph
 
Reported: 2014-03-22 13:00 PDT by Filip Pizlo
Modified: 2014-03-24 08:30 PDT (History)
10 users (show)

See Also:

Attachments
less than half way there (37.69 KB, patch)
2014-03-22 13:01 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
it builds on 64-bit (56.78 KB, patch)
2014-03-22 14:35 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
starting to work on 64-bit x86 (61.30 KB, patch)
2014-03-22 15:45 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (68.71 KB, patch)
2014-03-22 20:06 PDT, Filip Pizlo 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-03-22 13:00:56 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2014-03-22 13:01:43 PDT 
Created attachment 227564 [details]
less than half way there
Comment 2 Filip Pizlo 2014-03-22 14:35:24 PDT 
Created attachment 227574 [details]
it builds on 64-bit

It even appears to pass testapi, but I'm sure it has many, many bugs.
Comment 3 Filip Pizlo 2014-03-22 15:45:56 PDT 
Created attachment 227576 [details]
starting to work on 64-bit x86
Comment 4 Filip Pizlo 2014-03-22 20:06:05 PDT 
Created attachment 227595 [details]
the patch
Comment 5 Andreas Kling 2014-03-22 21:26:19 PDT 
Comment on attachment 227595 [details]
the patch

r=me

I'd suggest using "auto" instead of Bag<T>::iterator, since you seem to like short lines. ;)
Comment 6 Filip Pizlo 2014-03-22 21:35:10 PDT 
(In reply to comment #5)
> (From update of attachment 227595 [details])
> r=me
> 
> I'd suggest using "auto" instead of Bag<T>::iterator, since you seem to like short lines. ;)

I did it!
Comment 7 Filip Pizlo 2014-03-22 21:35:34 PDT 
Landed in http://trac.webkit.org/changeset/166135
Comment 8 Simon Fraser (smfr) 2014-03-23 09:49:54 PDT 
This broke the CLOOP build.
Comment 9 Csaba Osztrogonác 2014-03-24 08:30:11 PDT 
(In reply to comment #8)
> This broke the CLOOP build.

new bug report for fixing the build: https://bugs.webkit.org/show_bug.cgi?id=130670