Bug 130639 - Switch HTMLConverter to use CSSPropertyIDs to refer to CSS properties
Summary: Switch HTMLConverter to use CSSPropertyIDs to refer to CSS properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on: 130640
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-22 10:29 PDT by Sam Weinig
Modified: 2014-03-22 18:20 PDT (History)
3 users (show)

See Also:


Attachments
Patch (38.61 KB, patch)
2014-03-22 10:33 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (260.79 KB, application/zip)
2014-03-22 11:38 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (759.53 KB, application/zip)
2014-03-22 12:18 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (245.77 KB, application/zip)
2014-03-22 12:42 PDT, Build Bot
no flags Details
Patch (38.94 KB, patch)
2014-03-22 17:16 PDT, Sam Weinig
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2014-03-22 10:29:29 PDT
Switch HTMLConverter to use CSSPropertyIDs to refer to CSS properties
Comment 1 Sam Weinig 2014-03-22 10:33:35 PDT
Created attachment 227552 [details]
Patch
Comment 2 Sam Weinig 2014-03-22 11:01:44 PDT
Committed r166118: <http://trac.webkit.org/changeset/166118>
Comment 3 Geoffrey Garen 2014-03-22 11:28:33 PDT
Comment on attachment 227552 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227552&action=review

> Source/WebCore/ChangeLog:12
> +          that will alway yield the same results.

"always"
Comment 4 WebKit Commit Bot 2014-03-22 11:29:10 PDT
Re-opened since this is blocked by bug 130640
Comment 5 Build Bot 2014-03-22 11:38:07 PDT
Comment on attachment 227552 [details]
Patch

Attachment 227552 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6059695974383616

New failing tests:
editing/selection/mixed-editability-1.html
editing/selection/last-empty-inline.html
editing/selection/inline-closest-leaf-child.html
editing/selection/focus-crash.html
editing/selection/drag-select-1.html
editing/execCommand/find-after-replace.html
editing/selection/drag-to-contenteditable-iframe.html
editing/selection/empty-cell-right-click.html
editing/selection/4895428-1.html
editing/spelling/grammar-markers-hidpi.html
editing/selection/paragraph-granularity.html
editing/inserting/insert-3786362-fix.html
editing/selection/expanding-selections2.html
editing/selection/extend-after-mouse-selection.html
editing/selection/4895428-4.html
editing/selection/hit-test-anonymous.html
editing/selection/hit-test-on-text-with-line-height.html
editing/selection/fake-doubleclick.html
editing/selection/editable-links.html
editing/selection/extend-selection-after-double-click.html
editing/selection/contains-boundaries.html
editing/deleting/paste-with-transparent-background-color.html
editing/selection/mixed-editability-10.html
editing/selection/expanding-selections.html
editing/selection/fake-drag.html
editing/selection/drag-select-rapidly.html
editing/pasteboard/19644-1.html
editing/selection/focus-and-display-none.html
editing/input/reveal-contenteditable-on-paste-vertically.html
editing/selection/drag-start-event-client-x-y.html
Comment 6 Build Bot 2014-03-22 11:38:10 PDT
Created attachment 227557 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 7 Build Bot 2014-03-22 12:18:07 PDT
Comment on attachment 227552 [details]
Patch

Attachment 227552 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5072050259492864

New failing tests:
fast/forms/input-paste-undo.html
editing/pasteboard/3976872.html
editing/selection/select-crash-001.html
editing/selection/select-crash-002.html
editing/pasteboard/4242293.html
editing/selection/drag-in-iframe.html
editing/selection/programmatic-selection-on-mac-is-directionless.html
fast/repaint/obscured-background-no-repaint.html
editing/execCommand/paste-1.html
editing/pasteboard/4076267-3.html
editing/inserting/insert-paste-bidi-control.html
editing/selection/crash-on-drag-with-mutation-events.html
editing/input/reveal-edit-on-paste-vertically.html
editing/deleting/paste-with-transparent-background-color.html
editing/style/font-family-with-space.html
editing/undo/undo-paste-when-caret-is-not-in-range.html
editing/pasteboard/4076267.html
http/tests/misc/copy-resolves-urls.html
editing/pasteboard/19644-2.html
editing/style/5065910.html
editing/pasteboard/4922709.html
editing/style/apply-through-end-of-document.html
editing/pasteboard/19644-1.html
editing/pasteboard/4076267-2.html
http/tests/security/drag-drop-different-origin.html
editing/pasteboard/4944770-1.html
editing/pasteboard/4242293-1.html
editing/input/reveal-contenteditable-on-paste-vertically.html
fast/forms/plaintext-mode-2.html
editing/pasteboard/4641033.html
Comment 8 Build Bot 2014-03-22 12:18:10 PDT
Created attachment 227560 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 9 Build Bot 2014-03-22 12:42:42 PDT
Comment on attachment 227552 [details]
Patch

Attachment 227552 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4762069584838656

New failing tests:
editing/selection/mixed-editability-1.html
editing/selection/last-empty-inline.html
editing/selection/inline-closest-leaf-child.html
editing/selection/focus-crash.html
editing/selection/drag-select-1.html
editing/execCommand/find-after-replace.html
editing/selection/drag-to-contenteditable-iframe.html
editing/selection/empty-cell-right-click.html
editing/selection/4895428-1.html
editing/spelling/grammar-markers-hidpi.html
editing/selection/paragraph-granularity.html
editing/inserting/insert-3786362-fix.html
editing/selection/expanding-selections2.html
editing/selection/extend-after-mouse-selection.html
editing/selection/4895428-4.html
editing/selection/hit-test-anonymous.html
editing/selection/hit-test-on-text-with-line-height.html
editing/selection/fake-doubleclick.html
editing/selection/editable-links.html
editing/selection/extend-selection-after-double-click.html
editing/selection/contains-boundaries.html
editing/deleting/paste-with-transparent-background-color.html
editing/selection/mixed-editability-10.html
editing/selection/expanding-selections.html
editing/selection/fake-drag.html
editing/selection/drag-select-rapidly.html
editing/pasteboard/19644-1.html
editing/selection/focus-and-display-none.html
editing/input/reveal-contenteditable-on-paste-vertically.html
editing/selection/drag-start-event-client-x-y.html
Comment 10 Build Bot 2014-03-22 12:42:44 PDT
Created attachment 227563 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 11 Sam Weinig 2014-03-22 17:16:56 PDT
Created attachment 227583 [details]
Patch
Comment 12 Sam Weinig 2014-03-22 18:20:53 PDT
Re-landed in r166132.