Bug 130639 – Switch HTMLConverter to use CSSPropertyIDs to refer to CSS properties

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Switch HTMLConverter to use CSSPropertyIDs to refer to CSS properties

[Sam Weinig]

Created attachment 227552 [details]
Patch

[Sam Weinig]

Committed r166118: <http://trac.webkit.org/changeset/166118>

[Geoffrey Garen]

Comment on attachment 227552 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227552&action=review

> Source/WebCore/ChangeLog:12
> +          that will alway yield the same results.

"always"

[WebKit Commit Bot]

Re-opened since this is blocked by bug 130640

[Build Bot]

Comment on attachment 227552 [details]
Patch

Attachment 227552 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6059695974383616

New failing tests:
editing/selection/mixed-editability-1.html
editing/selection/last-empty-inline.html
editing/selection/inline-closest-leaf-child.html
editing/selection/focus-crash.html
editing/selection/drag-select-1.html
editing/execCommand/find-after-replace.html
editing/selection/drag-to-contenteditable-iframe.html
editing/selection/empty-cell-right-click.html
editing/selection/4895428-1.html
editing/spelling/grammar-markers-hidpi.html
editing/selection/paragraph-granularity.html
editing/inserting/insert-3786362-fix.html
editing/selection/expanding-selections2.html
editing/selection/extend-after-mouse-selection.html
editing/selection/4895428-4.html
editing/selection/hit-test-anonymous.html
editing/selection/hit-test-on-text-with-line-height.html
editing/selection/fake-doubleclick.html
editing/selection/editable-links.html
editing/selection/extend-selection-after-double-click.html
editing/selection/contains-boundaries.html
editing/deleting/paste-with-transparent-background-color.html
editing/selection/mixed-editability-10.html
editing/selection/expanding-selections.html
editing/selection/fake-drag.html
editing/selection/drag-select-rapidly.html
editing/pasteboard/19644-1.html
editing/selection/focus-and-display-none.html
editing/input/reveal-contenteditable-on-paste-vertically.html
editing/selection/drag-start-event-client-x-y.html

[Build Bot]

Created attachment 227557 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 227552 [details]
Patch

Attachment 227552 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5072050259492864

New failing tests:
fast/forms/input-paste-undo.html
editing/pasteboard/3976872.html
editing/selection/select-crash-001.html
editing/selection/select-crash-002.html
editing/pasteboard/4242293.html
editing/selection/drag-in-iframe.html
editing/selection/programmatic-selection-on-mac-is-directionless.html
fast/repaint/obscured-background-no-repaint.html
editing/execCommand/paste-1.html
editing/pasteboard/4076267-3.html
editing/inserting/insert-paste-bidi-control.html
editing/selection/crash-on-drag-with-mutation-events.html
editing/input/reveal-edit-on-paste-vertically.html
editing/deleting/paste-with-transparent-background-color.html
editing/style/font-family-with-space.html
editing/undo/undo-paste-when-caret-is-not-in-range.html
editing/pasteboard/4076267.html
http/tests/misc/copy-resolves-urls.html
editing/pasteboard/19644-2.html
editing/style/5065910.html
editing/pasteboard/4922709.html
editing/style/apply-through-end-of-document.html
editing/pasteboard/19644-1.html
editing/pasteboard/4076267-2.html
http/tests/security/drag-drop-different-origin.html
editing/pasteboard/4944770-1.html
editing/pasteboard/4242293-1.html
editing/input/reveal-contenteditable-on-paste-vertically.html
fast/forms/plaintext-mode-2.html
editing/pasteboard/4641033.html

[Build Bot]

Created attachment 227560 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 227552 [details]
Patch

Attachment 227552 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4762069584838656

New failing tests:
editing/selection/mixed-editability-1.html
editing/selection/last-empty-inline.html
editing/selection/inline-closest-leaf-child.html
editing/selection/focus-crash.html
editing/selection/drag-select-1.html
editing/execCommand/find-after-replace.html
editing/selection/drag-to-contenteditable-iframe.html
editing/selection/empty-cell-right-click.html
editing/selection/4895428-1.html
editing/spelling/grammar-markers-hidpi.html
editing/selection/paragraph-granularity.html
editing/inserting/insert-3786362-fix.html
editing/selection/expanding-selections2.html
editing/selection/extend-after-mouse-selection.html
editing/selection/4895428-4.html
editing/selection/hit-test-anonymous.html
editing/selection/hit-test-on-text-with-line-height.html
editing/selection/fake-doubleclick.html
editing/selection/editable-links.html
editing/selection/extend-selection-after-double-click.html
editing/selection/contains-boundaries.html
editing/deleting/paste-with-transparent-background-color.html
editing/selection/mixed-editability-10.html
editing/selection/expanding-selections.html
editing/selection/fake-drag.html
editing/selection/drag-select-rapidly.html
editing/pasteboard/19644-1.html
editing/selection/focus-and-display-none.html
editing/input/reveal-contenteditable-on-paste-vertically.html
editing/selection/drag-start-event-client-x-y.html

[Build Bot]

Created attachment 227563 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Sam Weinig]

Created attachment 227583 [details]
Patch

[Sam Weinig]

Re-landed in r166132.