Bug 130627 - Don't flush compositing layers within FrameView::willPaintContents()
Summary: Don't flush compositing layers within FrameView::willPaintContents()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
: 123753 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-03-21 18:32 PDT by Simon Fraser (smfr)
Modified: 2014-03-22 10:53 PDT (History)
6 users (show)

See Also:


Attachments
Patch (9.97 KB, patch)
2014-03-21 18:51 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (499.50 KB, application/zip)
2014-03-21 19:48 PDT, Build Bot
no flags Details
Patch (10.77 KB, patch)
2014-03-21 20:21 PDT, Simon Fraser (smfr)
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-03-21 18:32:27 PDT
Don't flush compositing layers within FrameView::willPaintContents()
Comment 1 Simon Fraser (smfr) 2014-03-21 18:51:40 PDT
Created attachment 227523 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-03-21 18:52:17 PDT
*** Bug 123753 has been marked as a duplicate of this bug. ***
Comment 3 Simon Fraser (smfr) 2014-03-21 18:54:46 PDT
<rdar://problem/16368869>
Comment 4 Build Bot 2014-03-21 19:48:27 PDT
Comment on attachment 227523 [details]
Patch

Attachment 227523 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5167235324706816

New failing tests:
media/W3C/audio/canPlayType/canPlayType_application_octet_stream.html
Comment 5 Build Bot 2014-03-21 19:48:30 PDT
Created attachment 227525 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 6 Simon Fraser (smfr) 2014-03-21 20:21:50 PDT
Created attachment 227527 [details]
Patch
Comment 7 Sam Weinig 2014-03-22 10:47:52 PDT
Comment on attachment 227527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227527&action=review

> Source/WebKit/mac/ChangeLog:26
> +2014-03-21  Simon Fraser  <simon.fraser@apple.com>
> +
> +        Don't flush compositing layers within FrameView::willPaintContents()
> +        https://bugs.webkit.org/show_bug.cgi?id=130627
> +
> +        Reviewed by NOBODY (OOPS!).
> +        
> +        Make _flushCompositingChanges private so DRT can call it;
> +        moved it into the Private category.
> +
> +        * WebView/WebView.mm:
> +        (-[WebView _flushCompositingChanges]):
> +        * WebView/WebViewPrivate.h:
> +
> +2014-03-21  Simon Fraser  <simon.fraser@apple.com>
> +
> +        Remove duplicate line added during merging
> +        https://bugs.webkit.org/show_bug.cgi?id=130623
> +
> +        Reviewed by Beth Dakin.
> +        
> +        Remove a duplicate call to -_viewWillDrawInternal which
> +        was added during merges.
> +
> +        * WebView/WebView.mm:
> +        (LayerFlushController::flushLayers):

Double ChangeLog!
Comment 8 Simon Fraser (smfr) 2014-03-22 10:53:02 PDT
https://trac.webkit.org/r166117