Bug 130627 – Don't flush compositing layers within FrameView::willPaintContents()

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Don't flush compositing layers within FrameView::willPaintContents()

[Simon Fraser (smfr)]

Created attachment 227523 [details]
Patch

[Simon Fraser (smfr)]

*** Bug 123753 has been marked as a duplicate of this bug. ***

[Simon Fraser (smfr)]

<rdar://problem/16368869>

[Build Bot]

Comment on attachment 227523 [details]
Patch

Attachment 227523 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5167235324706816

New failing tests:
media/W3C/audio/canPlayType/canPlayType_application_octet_stream.html

[Build Bot]

Created attachment 227525 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Simon Fraser (smfr)]

Created attachment 227527 [details]
Patch

[Sam Weinig]

Comment on attachment 227527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227527&action=review

> Source/WebKit/mac/ChangeLog:26
> [phone]  Simon Fraser  <[e-mail]>
> +
> +        Don't flush compositing layers within FrameView::willPaintContents()
> +        https://bugs.webkit.org/show_bug.cgi?id=130627
> +
> +        Reviewed by NOBODY (OOPS!).
> +        
> +        Make _flushCompositingChanges private so DRT can call it;
> +        moved it into the Private category.
> +
> +        * WebView/WebView.mm:
> +        (-[WebView _flushCompositingChanges]):
> +        * WebView/WebViewPrivate.h:
> +
> [phone]  Simon Fraser  <[e-mail]>
> +
> +        Remove duplicate line added during merging
> +        https://bugs.webkit.org/show_bug.cgi?id=130623
> +
> +        Reviewed by Beth Dakin.
> +        
> +        Remove a duplicate call to -_viewWillDrawInternal which
> +        was added during merges.
> +
> +        * WebView/WebView.mm:
> +        (LayerFlushController::flushLayers):

Double ChangeLog!

[Simon Fraser (smfr)]

https://trac.webkit.org/r166117