RESOLVED FIXED 130626
[WK2] Make updates on ViewUpdateDispatcher less heavy 
https://bugs.webkit.org/show_bug.cgi?id=130626
Summary [WK2] Make updates on ViewUpdateDispatcher less heavy
Benjamin Poulain
Reported 2014-03-21 18:10:19 PDT
[WK2] Make updates on ViewUpdateDispatcher less heavy
Attachments
Patch (2.98 KB, patch)
2014-03-21 18:10 PDT, Benjamin Poulain 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-03-21 18:10:36 PDT
Created attachment 227520 [details] Patch
Darin Adler
Comment 2 2014-03-22 08:06:04 PDT
Comment on attachment 227520 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227520&action=review > Source/WebKit2/WebProcess/WebPage/ViewUpdateDispatcher.cpp:74 > localCopy.swap(m_latestUpdate); This should really use std::move instead of swap. Swap was the hack for doing this before we had move assignment. Also, the code below uses the word “iterator” strangely. It should be written like this: for (uint64_t pageID : localCopy.keys())
Darin Adler
Comment 3 2014-03-22 08:06:55 PDT
Comment on attachment 227520 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227520&action=review >> Source/WebKit2/WebProcess/WebPage/ViewUpdateDispatcher.cpp:74 >> localCopy.swap(m_latestUpdate); > > This should really use std::move instead of swap. Swap was the hack for doing this before we had move assignment. > > Also, the code below uses the word “iterator” strangely. It should be written like this: > > for (uint64_t pageID : localCopy.keys()) Oops, that was wrong. Obviously we want both keys and values. I just don’t think that “iterator” is the right name for an entry in a HashMap. I suggest the name "slot".
Benjamin Poulain
Comment 4 2014-03-24 13:58:37 PDT
Committed r166191: <http://trac.webkit.org/changeset/166191>
Note You need to log in before you can comment on or make changes to this bug.