Bug 130619 - REGRESSION (r165356): Predictive Chinese input is broken
Summary: REGRESSION (r165356): Predictive Chinese input is broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-21 14:59 PDT by Alexey Proskuryakov
Modified: 2014-03-21 15:59 PDT (History)
3 users (show)

See Also:

Attachments
proposed patch (1.42 KB, patch)
2014-03-21 15:02 PDT, Alexey Proskuryakov 		enrica: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-03-21 14:59:48 PDT 
Predictive Chinese input is very special - it doesn't have an inline input area, but critically depends on us calling -discardMarkedText at exactly the right times.

Changes in when editor state is updated resulted in us calling it too eagerly. Updating editor state was and remains hopelessly broken, thankfully, we will not depend on it as much with async input.

Steps to reproduce:
1. Enable Cangjie input.
2. Type "sina"
3. Press "1" several times.

Expected results: each time "1" is pressed, something is inserted, and a new suggestion popup appears.
Actual results: After the first time, there is no suggestion popup.
Comment 1 Alexey Proskuryakov 2014-03-21 15:02:39 PDT 
Created attachment 227495 [details]
proposed patch
Comment 2 Enrica Casucci 2014-03-21 15:54:05 PDT 
Comment on attachment 227495 [details]
proposed patch

Looks good.
Comment 3 Alexey Proskuryakov 2014-03-21 15:59:07 PDT 
Committed <http://trac.webkit.org/r166105>.