Bug 130614 - Refactoring the BytecodeGenerator to use a BytecodeGeneratorVector.
Summary: Refactoring the BytecodeGenerator to use a BytecodeGeneratorVector.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-21 13:41 PDT by Mark Lam
Modified: 2014-03-21 13:54 PDT (History)
2 users (show)

See Also:

Attachments
the patch. (3.03 KB, patch)
2014-03-21 13:46 PDT, Mark Lam 		mark.lam: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-03-21 13:41:02 PDT 
Introducing a BytecodeGeneratorVector for the purpose of pointing out the way the BytecodeGenerator uses element in those vectors i.e. it can retain references to elements in the vector while new elements are added, or some elements are removed.  The BytecodeGeneratorVector is implemented as a SegmentedVector.  The BytecodeGenerator will now use the BytecodeGeneratorVector instead of the SegmentedVector.
Comment 1 Mark Lam 2014-03-21 13:46:09 PDT 
Created attachment 227485 [details]
the patch.
Comment 2 Mark Lam 2014-03-21 13:54:41 PDT 
Fil pointed out that the use of SegmentedVector already adequately indicate the information about how the BytecodeGenerator uses those vector elements.  At this point, there's no added benefit to doing this.  So, I'll retract the patch.