Bug 130612 – Replace deprecatedIsCollapsibleWhitespace with RenderStyle::isCollapsibleWhiteSpace in TextIterator

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Chang Shu]

RenderStyle::isCollapsibleWhiteSpace is more accurate on determine a whitespace is collapsible.

[Chang Shu]

Created attachment 227468 [details]
fix patch

[Build Bot]

Comment on attachment 227468 [details]
fix patch

Attachment 227468 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4676147153469440

New failing tests:
fast/html/object-border.html
fast/xsl/mozilla-tests.xml
fast/table/cell-in-row-before-misnested-text-crash.xhtml
fast/dom/Element/offsetTop-table-cell.html
platform/mac/accessibility/table-multi-bodies.html
fast/tokenizer/script_extra_close.html
platform/mac/accessibility/aria-grid-with-strange-hierarchy.html
accessibility/table-scope.html
fast/table/cell-in-row-before-misnested-text-crash-css.html

[Build Bot]

Created attachment 227471 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 227468 [details]
fix patch

Attachment 227468 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5110843209416704

New failing tests:
fast/html/object-border.html
fast/xsl/mozilla-tests.xml
fast/table/cell-in-row-before-misnested-text-crash.xhtml
fast/table/cell-in-row-before-misnested-text-crash-css.html
platform/mac/accessibility/table-multi-bodies.html
fast/tokenizer/script_extra_close.html
platform/mac/accessibility/aria-grid-with-strange-hierarchy.html
accessibility/table-scope.html
fast/dom/Element/offsetTop-table-cell.html

[Build Bot]

Created attachment 227478 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Chang Shu]

Created attachment 227490 [details]
more tests need rebase

[Build Bot]

Comment on attachment 227490 [details]
more tests need rebase

Attachment 227490 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4970658966536192

New failing tests:
fast/dom/Element/offsetTop-table-cell.html

[Build Bot]

Created attachment 227500 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 227490 [details]
more tests need rebase

Attachment 227490 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6274439238909952

New failing tests:
fast/dom/Element/offsetTop-table-cell.html

[Build Bot]

Created attachment 227505 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 227490 [details]
more tests need rebase

Attachment 227490 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6241316451123200

New failing tests:
fast/dom/Element/offsetTop-table-cell.html

[Build Bot]

Created attachment 227506 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Chang Shu]

Created attachment 227587 [details]
fix patch

[Darin Adler]

Comment on attachment 227587 [details]
fix patch

Does this get rid of all deprecatedIsCollapsibleWhitespace? Or are we still stuck with it in some places?

Great change! Please land only if all tests pass, so lets wait for EWS.

[Chang Shu]

(In reply to comment #14)
> (From update of attachment 227587 [details])
> Does this get rid of all deprecatedIsCollapsibleWhitespace? Or are we still stuck with it in some places?
> 
> Great change! Please land only if all tests pass, so lets wait for EWS.

Thanks, Darin. The patch only removes all instances in TextIterator. There are still a few in other files like Position.cpp. I didn't remove all of them in one shot as I was afraid the regressions would be too much and I wasn't able to tell if some of them could be real problem. I will try to clean up all of them in the next patch.

[WebKit Commit Bot]

Comment on attachment 227587 [details]
fix patch

Clearing flags on attachment: 227587

Committed r166134: <http://trac.webkit.org/changeset/166134>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.