Include WTF headers in the WebCore precompiled headers
Created attachment 227456 [details] Patch
Attachment 227456 [details] did not pass style-queue: ERROR: Source/WebCore/WebCorePrefix.h:180: Header file should not contain WebCore config.h. Should be: alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/WebCorePrefix.h:183: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/WebCorePrefix.h:187: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/WebCorePrefix.h:196: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/WebCorePrefix.h:217: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/WebCorePrefix.h:226: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/WebCorePrefix.h:247: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/WebCorePrefix.h:257: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/WebCorePrefix.h:290: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/WebCorePrefix.h:313: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/WebCorePrefix.h:325: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/WebCorePrefix.h:330: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/WebCorePrefix.h:336: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/WebCorePrefix.h:337: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/WebCorePrefix.h:341: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/WebCorePrefix.h:344: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 16 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
I think if we land this, we need to encourage a culture of not making frequent changes to WTF headers.
(In reply to comment #3) > I think if we land this, we need to encourage a culture of not making frequent changes to WTF headers. This culture should have been in place already, but yes. :) Windows build failure: 1>C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\include\private\wtf/ObjcRuntimeExtras.h(31): fatal error C1083: Cannot open include file: 'objc/message.h': No such file or directory
(In reply to comment #4) > (In reply to comment #3) > > I think if we land this, we need to encourage a culture of not making frequent changes to WTF headers. > > This culture should have been in place already, but yes. :) > > Windows build failure: > 1>C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\include\private\wtf/ObjcRuntimeExtras.h(31): fatal error C1083: Cannot open include file: 'objc/message.h': No such file or directory Just bracket this include with the #if !OS(WINDOWS)
Decided against this; the precompiled header and prefix header are the same thing, and if we include WTF on mac it will be too easy to break other platforms.