Bug 130601 – Replace DEPRECATED_DEFINE_STATIC_LOCAL by static NeverDestroyed<T> in bridge/

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sergio Villar Senin]

Replace DEPRECATED_DEFINE_STATIC_LOCAL by static NeverDestroyed<T> in bridge/

[Sergio Villar Senin]

Created attachment 227448 [details]
Patch

[Darin Adler]

Comment on attachment 227448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227448&action=review

> Source/WebCore/bridge/runtime_root.cpp:65
> -    RootObjectSet::const_iterator end = rootObjectSet()->end();
> -    for (RootObjectSet::const_iterator it = rootObjectSet()->begin(); it != end; ++it) {
> +    RootObjectSet::const_iterator end = rootObjectSet().end();
> +    for (RootObjectSet::const_iterator it = rootObjectSet().begin(); it != end; ++it) {
>          if ((*it)->gcIsProtected(jsObject))
>              return *it;
>      }

I would’ve switched to a new style for loop if I had to touch this code for another reason.

    for (auto* rootObject : rootObjectSet()) {
        if (rootObject->gcIsProtected(jsObject))
            return rootObject;
    }

> Source/WebCore/bridge/runtime_root.cpp:75
> -    RootObjectSet::const_iterator end = rootObjectSet()->end();
> -    for (RootObjectSet::const_iterator it = rootObjectSet()->begin(); it != end; ++it) {
> +    RootObjectSet::const_iterator end = rootObjectSet().end();
> +    for (RootObjectSet::const_iterator it = rootObjectSet().begin(); it != end; ++it) {
>          if ((*it)->globalObject() == globalObject)
>              return *it;
>      }

I would’ve switched to a new style for loop if I had to touch this code for another reason.

    for (auto* rootObject : rootObjectSet()) {
        if (rootObject->globalObject() == globalObject)
            return rootObject;
    }

[Sergio Villar Senin]

Committed r166071: <http://trac.webkit.org/changeset/166071>