Bug 130599 - [GTK] Add support for GTK3 plugins
Summary: [GTK] Add support for GTK3 plugins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2014-03-21 09:25 PDT by Carlos Garcia Campos
Modified: 2014-03-31 03:39 PDT (History)
8 users (show)

See Also:


Attachments
Patch (14.94 KB, patch)
2014-03-21 09:35 PDT, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-03-21 09:25:56 PDT
We currently have a gtk2 based plugin process mainly for flash (which is very sad) and a few other plugins that use gtk2, but many other plugins don't even use gtk at all. We could build a lighter plugin process based on GTK3, used by default for all the plugins expect the ones requiring GTK2. And of course the default plugin process will support GTK3 plugins.
Comment 1 Carlos Garcia Campos 2014-03-21 09:35:04 PDT
Created attachment 227446 [details]
Patch

$ ls -lh bin/WebKitPluginProcess*
-rwxr-xr-x 1 cgarcia cgarcia 7,4K mar 21 17:05 bin/WebKitPluginProcess
-rwxr-xr-x 1 cgarcia cgarcia  43M mar 21 17:05 bin/WebKitPluginProcess2
Comment 2 Martin Robinson 2014-03-27 08:32:08 PDT
Comment on attachment 227446 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227446&action=review

> Source/WebKit2/PlatformGTK.cmake:524
> +    set(PluginProcess2_EXECUTABLE_NAME WebKitPluginProcess2)
> +    list(APPEND PluginProcess2_INCLUDE_DIRECTORIES

We use WebCorePlatformGTK2, so I think this should be PluginProcessGTK2 to maintain consistency.

> Source/WebKit2/PlatformGTK.cmake:630
> -    list(APPEND PluginProcess_MESSAGES_IN_FILES
> +    list(APPEND PluginProcess2_MESSAGES_IN_FILES
>          PluginProcess/PluginControllerProxy.messages.in
>          PluginProcess/PluginProcess.messages.in
>          PluginProcess/WebProcessConnection.messages.in
>  
>          Shared/Plugins/NPObjectMessageReceiver.messages.in
>      )
> -    GENERATE_WEBKIT2_MESSAGE_SOURCES(PluginProcess_SOURCES "${PluginProcess_MESSAGES_IN_FILES}")
> +    GENERATE_WEBKIT2_MESSAGE_SOURCES(PluginProcess2_SOURCES "${PluginProcess2_MESSAGES_IN_FILES}")

These files are generated in the shared CMakeLists.txt file now, so I think we can just remove these lines.
Comment 3 Carlos Garcia Campos 2014-03-31 03:39:42 PDT
Committed r166492: <http://trac.webkit.org/changeset/166492>