Bug 130589 - [webkitpy] Fix has_valid_reviewer()
Summary: [webkitpy] Fix has_valid_reviewer()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-21 06:42 PDT by Éva Balázsfalvi
Modified: 2014-03-21 07:50 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.82 KB, patch)
2014-03-21 06:46 PDT, Éva Balázsfalvi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Éva Balázsfalvi 2014-03-21 06:42:18 PDT
has_valid_reviewer() in Tools/Scripts/webkitpy/common/checkout/changelog.py
returns with true for committers too, not only for reviewers
Comment 1 Éva Balázsfalvi 2014-03-21 06:46:02 PDT
Created attachment 227427 [details]
Patch
Comment 2 Csaba Osztrogonác 2014-03-21 07:04:02 PDT
It's so ugly bug. :) The patch looks good to me. Gábor do you permit
us to use your name in the unittest? Unfortunately this test should
be updated once you become a reviewer. ;)
Comment 3 Gabor Rapcsanyi 2014-03-21 07:11:05 PDT
(In reply to comment #2)
> It's so ugly bug. :) The patch looks good to me. Gábor do you permit
> us to use your name in the unittest? Unfortunately this test should
> be updated once you become a reviewer. ;)

Of course, I'm honored :)
Comment 4 Csaba Osztrogonác 2014-03-21 07:17:14 PDT
Comment on attachment 227427 [details]
Patch

OK, r=me
Comment 5 WebKit Commit Bot 2014-03-21 07:50:02 PDT
Comment on attachment 227427 [details]
Patch

Clearing flags on attachment: 227427

Committed r166062: <http://trac.webkit.org/changeset/166062>
Comment 6 WebKit Commit Bot 2014-03-21 07:50:05 PDT
All reviewed patches have been landed.  Closing bug.