Bug 130574 – [CSS Regions] The background of children of scrollable elements flowed into regions is not properly scrolled

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Radu Stavila]

Created attachment 227406 [details]
Test-case

The background of children of elements flowed into scrollable regions is not properly scrolled. See attached test-case.

[Radu Stavila]

Created attachment 227432 [details]
Patch

[Radu Stavila]

Created attachment 227433 [details]
Patch

[Dave Hyatt]

Comment on attachment 227433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227433&action=review

> Source/WebCore/rendering/RenderNamedFlowThread.cpp:307
> +    // Take the scrolled offset of this object's parents into consideration.
> +    IntSize scrolledContentOffset;
> +    RenderElement* parent = box.parent();
> +    while (parent) {
> +        if (parent->isBox()) {
> +            RenderBox* parentBox = toRenderBox(parent);
> +            if (parentBox->isRenderNamedFlowThread()) {

Don't we have a function to get the enclosing named flow thread for a box? Pretty sure we do, in which case writing this loop yourself seems like extra code?

[Radu Stavila]

Created attachment 227443 [details]
Patch integrating feedback

[Dave Hyatt]

Comment on attachment 227443 [details]
Patch integrating feedback

r=me

[WebKit Commit Bot]

Comment on attachment 227443 [details]
Patch integrating feedback

Clearing flags on attachment: 227443

Committed r166259: <http://trac.webkit.org/changeset/166259>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.