Bug 130567 - [EFL][WK2] Remove Ewk_Error parameter from some async callbacks
Summary: [EFL][WK2] Remove Ewk_Error parameter from some async callbacks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-21 00:07 PDT by Ryuan Choi
Modified: 2014-03-21 00:59 PDT (History)
6 users (show)

See Also:


Attachments
Patch (15.09 KB, patch)
2014-03-21 00:29 PDT, Ryuan Choi
no flags Details | Formatted Diff | Diff
Patch (15.09 KB, patch)
2014-03-21 00:55 PDT, Ryuan Choi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2014-03-21 00:07:37 PDT
WebKit2 internally use GenericCallbacks for several APIs such as WKKeyValueStorageManagerGetKeyValueStorageOrigins.
But only few callbacks really return errors.

So this parameters just make confusion for application developers.
Comment 1 Ryuan Choi 2014-03-21 00:29:32 PDT
Created attachment 227389 [details]
Patch
Comment 2 Gyuyoung Kim 2014-03-21 00:41:09 PDT
Comment on attachment 227389 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227389&action=review

> Source/WebKit2/ChangeLog:8
> +        WebKit2 internally use GenericCallbacks for several APIs such as WKKeyValueStorageManagerGetKeyValueStorageOrigins.

use - > uses ?

> Source/WebKit2/ChangeLog:11
> +        This patch removed Ewk_Error parameters from these callbask not to make

removed -> removes ?
callbask -> callbacks ?
Comment 3 Ryuan Choi 2014-03-21 00:55:47 PDT
Created attachment 227394 [details]
Patch
Comment 4 Ryuan Choi 2014-03-21 00:59:03 PDT
Comment on attachment 227394 [details]
Patch

Clearing flags on attachment: 227394

Committed r166051: <http://trac.webkit.org/changeset/166051>
Comment 5 Ryuan Choi 2014-03-21 00:59:12 PDT
All reviewed patches have been landed.  Closing bug.