Bug 130565 – Merge WebVTT Tokenizer Updates

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Brent Fulgham]

Merge a number of WebVTT Tokenizer fixes and improvements from Blink:

1. Simplify state handling in WebVTTTokenizer::nextToken
	923db263aa65d6efd71c5b55708ad7eea6b23f53
	https://codereview.chromium.org/73813002
	
	[e-mail]

2. Defer setting type in the WebVTT tokenizer until emitting the token
	48375b1d56b2d8850ae93a6c6fb01c69fae82c75
	https://codereview.chromium.org/77553004
	
	[e-mail]

3. Remove state-specific appendTo*/begin* methods from VTTToken
    98d4fc4f5cb716a31d11907120b10538d4ba0f09
	https://codereview.chromium.org/78833002
	
	[e-mail]

4. Turn VTTToken into an immutable object
	0e53d4f9f140e979b7f32de495551684bc7f4cd2
	https://codereview.chromium.org/81113003
	
	[e-mail]

5. Fix corner-cases for WebVTT tokenizer escape handling
	730ef1e7f9a1919964f7e74e7ccb2f343e10a148
	https://codereview.chromium.org/97103002
	
	[e-mail]

6. Cleanups for VTTTokenizer
	c373ee914ffabeaf833939129538251d8f2f4eca
	https://codereview.chromium.org/98763004
	
	[e-mail]

7. Split out common parsing code for Position/Size VTT cue settings
	4ddb4d57948228fa05e49e06bd58a1179c09f212
	https://codereview.chromium.org/118263002
	
	[e-mail]

[Radar WebKit Bug Importer]

<rdar://problem/16388178>

[Brent Fulgham]

Created attachment 227385 [details]
Patch

[Build Bot]

Comment on attachment 227385 [details]
Patch

Attachment 227385 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5683276450627584

New failing tests:
media/track/regions-webvtt/vtt-region-list.html
media/track/regions-webvtt/vtt-region-dom-layout.html
media/track/regions-webvtt/vtt-region-constructor.html
media/track/regions-webvtt/text-track-cue-region-attribute.html
media/track/regions-webvtt/vtt-region-display.html
media/track/regions-webvtt/vtt-region-parser.html
http/tests/media/track/track-webvtt-slow-loading.html

[Build Bot]

Created attachment 227386 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 227385 [details]
Patch

Attachment 227385 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5954750327554048

New failing tests:
media/track/regions-webvtt/vtt-region-list.html
media/track/regions-webvtt/vtt-region-dom-layout.html
media/track/regions-webvtt/vtt-region-constructor.html
media/track/regions-webvtt/text-track-cue-region-attribute.html
media/track/regions-webvtt/vtt-region-display.html
media/track/regions-webvtt/vtt-region-parser.html

[Build Bot]

Created attachment 227387 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Brent Fulgham]

Comment on attachment 227385 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227385&action=review

> LayoutTests/TestExpectations:15
> +#webkit.org/b/109570 media/track/regions-webvtt [ Skip ]

Obviously, this should not be checked in!

[Brent Fulgham]

Committed r166066: <http://trac.webkit.org/changeset/166066>