Bug 130534 – Move cross-port Source/WebCore/page/ code to std::unique_ptr

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zan Dobersek]

Move cross-port Source/WebCore/page/ code to std::unique_ptr

[Zan Dobersek]

Created attachment 227327 [details]
Patch

[WebKit Commit Bot]

Attachment 227327 [details] did not pass style-queue:


ERROR: Source/WebCore/page/Frame.cpp:165:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/page/Frame.cpp:166:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:770:  Wrong number of spaces before statement. (expected: 44)  [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:771:  Wrong number of spaces before statement. (expected: 44)  [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:777:  Wrong number of spaces before statement. (expected: 44)  [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:778:  Wrong number of spaces before statement. (expected: 44)  [whitespace/indent] [4]
Total errors found: 6 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Zan Dobersek]

Created attachment 227791 [details]
Patch

[WebKit Commit Bot]

Attachment 227791 [details] did not pass style-queue:


ERROR: Source/WebCore/page/Frame.cpp:165:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/page/Frame.cpp:166:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:770:  Wrong number of spaces before statement. (expected: 44)  [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:771:  Wrong number of spaces before statement. (expected: 44)  [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:777:  Wrong number of spaces before statement. (expected: 44)  [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:778:  Wrong number of spaces before statement. (expected: 44)  [whitespace/indent] [4]
Total errors found: 6 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brent Fulgham]

Comment on attachment 227791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227791&action=review

This looks good, but unfortunately seemed to choke in the EWS system for Mac.  Could you rebaseline and upload again so we can confirm it's okay?

> Source/WebCore/page/ContentSecurityPolicy.cpp:919
> +    std::unique_ptr<CSPDirectiveList> directives(new CSPDirectiveList(policy, type));

Why not auto directives = std::make_unique<CSPDirectiveList>(policy, type)?

[Zan Dobersek]

Created attachment 229773 [details]
Patch

[WebKit Commit Bot]

Attachment 229773 [details] did not pass style-queue:


ERROR: Source/WebCore/page/Frame.cpp:165:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/page/Frame.cpp:166:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:769:  Wrong number of spaces before statement. (expected: 44)  [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:770:  Wrong number of spaces before statement. (expected: 44)  [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:776:  Wrong number of spaces before statement. (expected: 44)  [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:777:  Wrong number of spaces before statement. (expected: 44)  [whitespace/indent] [4]
Total errors found: 6 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 229773 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229773&action=review

/Volumes/Data/EWS/WebKit/Source/WebKit/mac/WebView/WebHTMLRepresentation.mm:485:60: error: reference to type 'const JSC::Yarr::RegularExpression' could not bind to an lvalue of type 'JSC::Yarr::RegularExpression *'

r=me as long as you fix the Mac build

> Source/WebCore/page/DOMWindow.cpp:158
> +        // This object gets deleted when std::unique_ptr falls out of scope..
> +        std::unique_ptr<PostMessageTimer> timer(this);
> +        m_window->postMessageTimerFired(*timer);

Not sure this is better than just calling "delete this" at the end of the function.

> Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1087
> +    CSSPropertyAnimationWrapperMap();

Why not leave this private?

[Zan Dobersek]

Created attachment 229797 [details]
Patch for landing

Should fix the Mac build.

[Zan Dobersek]

Comment on attachment 229773 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229773&action=review

>> Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1087
>> +    CSSPropertyAnimationWrapperMap();
> 
> Why not leave this private?

It was made accessible to the NeverDestroyed constructor, but I now declared NeverDestroyed<CSSPropertyAnimationWrapperMap> as a friend instead.

[WebKit Commit Bot]

Attachment 229797 [details] did not pass style-queue:


ERROR: Source/WebCore/page/Frame.cpp:165:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/page/Frame.cpp:166:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:769:  Wrong number of spaces before statement. (expected: 44)  [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:770:  Wrong number of spaces before statement. (expected: 44)  [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:776:  Wrong number of spaces before statement. (expected: 44)  [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:777:  Wrong number of spaces before statement. (expected: 44)  [whitespace/indent] [4]
Total errors found: 6 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Zan Dobersek]

Comment on attachment 229797 [details]
Patch for landing

Clearing flags on attachment: 229797

Committed r167594: <http://trac.webkit.org/changeset/167594>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.