Bug 130532 - Add a flushing mechanism for the WebVTTParser
Summary: Add a flushing mechanism for the WebVTTParser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-03-20 13:14 PDT by Brent Fulgham
Modified: 2014-03-20 14:00 PDT (History)
14 users (show)

See Also:

Attachments
Patch (53.25 KB, patch)
2014-03-20 13:38 PDT, Brent Fulgham 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-03-20 13:14:03 PDT 
1. Use TextResourceDecoder for the WebVTTParser
	1ac2b3081492ab8661429230004013a9a3623f0f
	https://codereview.chromium.org/54203003
	
	fs@opera.com
	
2. Add a flushing mechanism for the WebVTTParser
	24343d32bc36d20d59ef3e10040faddde65929e6
	https://codereview.chromium.org/59453002
	
	fs@opera.com

3. Don't find(':') twice in WebVTTParser::collectMetadataHeader
	ef2793f1d9d207389589ecf9a136ea5c7170b4af
	https://codereview.chromium.org/75233002
	
	fs@opera.com

4. Decouple tokenizer/tree builder state from WebVTTParser
	a29f2f8324abcd4826b41e7dc34373dee2ec57a9
	https://codereview.chromium.org/52713005
	
	fs@opera.com

5. Handle buffer boundaries in the WebVTT parser
	7ce003c8d47b39f116f1f2a592a5dfb4a9e77228
	https://codereview.chromium.org/64303004
	
	fs@opera.com

6. Fix tag closing issues in the WebVTT tree builder
	18f896b3498478311e880f782813d5dfc8c0c7d1
	https://codereview.chromium.org/96933004
	
	fs@opera.com

7. WebVTT only allows <rt> if the currently innermost node is <ruby>
	8670e8ecb13254a651f5493ec83f4484d18c154e
	https://codereview.chromium.org/98783005
	
	fs@opera.com

8. Use the return value to signal success for VTTParser helpers
	4ac55780a6af3d76e0159c1d145330964ad56647
	https://codereview.chromium.org/104713002
	
	fs@opera.com
Comment 1 Radar WebKit Bug Importer 2014-03-20 13:14:49 PDT 
<rdar://problem/16382589>
Comment 2 Brent Fulgham 2014-03-20 13:38:30 PDT 
Created attachment 227326 [details]
Patch
Comment 3 Eric Carlson 2014-03-20 13:54:35 PDT 
Comment on attachment 227326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227326&action=review

> Source/WebCore/ChangeLog:64
> +2014-03-20  Brent Fulgham  <bfulgham@apple.com>
> +
> +        Need a short description (OOPS!).
> +        Need the bug URL (OOPS!).
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Tests: http/tests/media/track/track-webvtt-slow-loading-2.html
> +               http/tests/media/track/track-webvtt-slow-loading.html
> +
> +        * CMakeLists.txt:
> +        * Configurations/FeatureDefines.xcconfig:
> +        * GNUmakefile.list.am:
> +        * WebCore.vcxproj/WebCore.vcxproj:
> +        * WebCore.vcxproj/WebCore.vcxproj.filters:
> +        * WebCore.xcodeproj/project.pbxproj:
> +        * html/track/BufferedLineReader.cpp: Added.
> +        * html/track/BufferedLineReader.h: Added.
> +        * html/track/TextTrackRegion.cpp:
> +        * html/track/VTTCue.cpp:
> +        * html/track/WebVTTParser.cpp:
> +        * html/track/WebVTTParser.h:
> +        * loader/TextTrackLoader.cpp:

Oops!
Comment 4 Brent Fulgham 2014-03-20 14:00:22 PDT 
Committed r165997: <http://trac.webkit.org/changeset/165997>