Bug 130530 - Update iOS input method code to use new cross-platform async functions
Summary: Update iOS input method code to use new cross-platform async functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-20 13:00 PDT by Alexey Proskuryakov
Modified: 2014-03-20 14:18 PDT (History)
3 users (show)

See Also:

Attachments
proposed patch (31.58 KB, patch)
2014-03-20 13:47 PDT, Alexey Proskuryakov 		enrica: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-03-20 13:00:11 PDT 
iOS used to have async IPC calls like insertText whose names were the same as sync Mac methods, confusingly. Now that we have async methods in cross-platform code, it only makes sense to delete identical iOS implementations.
Comment 1 Alexey Proskuryakov 2014-03-20 13:47:32 PDT 
Created attachment 227328 [details]
proposed patch
Comment 2 Enrica Casucci 2014-03-20 14:07:44 PDT 
Comment on attachment 227328 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227328&action=review

Looks good.

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1510
> +    _page->insertTextAsync(aStringValue, EditingRange());

Are these methods implemented for both iOS and Mac?
Comment 3 Alexey Proskuryakov 2014-03-20 14:12:15 PDT 
Yes, they are under PLATFORM(COCOA) in WebPage.cpp.
Comment 4 Alexey Proskuryakov 2014-03-20 14:18:29 PDT 
Committed <http://trac.webkit.org/r165759>.