RESOLVED FIXED 130530
Update iOS input method code to use new cross-platform async functions 
https://bugs.webkit.org/show_bug.cgi?id=130530
Summary Update iOS input method code to use new cross-platform async functions
Alexey Proskuryakov
Reported 2014-03-20 13:00:11 PDT
iOS used to have async IPC calls like insertText whose names were the same as sync Mac methods, confusingly. Now that we have async methods in cross-platform code, it only makes sense to delete identical iOS implementations.
Attachments
proposed patch (31.58 KB, patch)
2014-03-20 13:47 PDT, Alexey Proskuryakov 		enrica: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-03-20 13:47:32 PDT
Created attachment 227328 [details] proposed patch
Enrica Casucci
Comment 2 2014-03-20 14:07:44 PDT
Comment on attachment 227328 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=227328&action=review Looks good. > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1510 > + _page->insertTextAsync(aStringValue, EditingRange()); Are these methods implemented for both iOS and Mac?
Alexey Proskuryakov
Comment 3 2014-03-20 14:12:15 PDT
Yes, they are under PLATFORM(COCOA) in WebPage.cpp.
Alexey Proskuryakov
Comment 4 2014-03-20 14:18:29 PDT
Committed <http://trac.webkit.org/r165759>.
Note You need to log in before you can comment on or make changes to this bug.