Bug 130528 - [WebKit2] Implement NetworkingContext::sourceApplicationAuditData() for WebKit2
Summary: [WebKit2] Implement NetworkingContext::sourceApplicationAuditData() for WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on: 130551
Blocks:
  Show dependency tree / graph
 
Reported: 2014-03-20 12:28 PDT by Sam Weinig
Modified: 2014-03-21 15:43 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.69 KB, patch)
2014-03-20 12:29 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (12.73 KB, patch)
2014-03-21 14:03 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (13.39 KB, patch)
2014-03-21 15:32 PDT, Sam Weinig 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2014-03-20 12:28:28 PDT 
[WebKit2] Implement NetworkingContext::sourceApplicationAuditData() for WebKit2
Comment 1 Sam Weinig 2014-03-20 12:29:27 PDT 
Created attachment 227318 [details]
Patch
Comment 2 Anders Carlsson 2014-03-20 12:30:38 PDT 
Comment on attachment 227318 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227318&action=review

> Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp:38
> +#if defined(__has_include) && __has_include(<xpc/private.h>)

No need for #if defined(__has_include).
Comment 3 Sam Weinig 2014-03-20 12:33:14 PDT 
Committed r165985: <http://trac.webkit.org/changeset/165985>
Comment 4 WebKit Commit Bot 2014-03-20 17:54:04 PDT 
Re-opened since this is blocked by bug 130551
Comment 5 Sam Weinig 2014-03-21 14:03:24 PDT 
Created attachment 227487 [details]
Patch
Comment 6 Sam Weinig 2014-03-21 15:32:22 PDT 
Created attachment 227499 [details]
Patch
Comment 7 Tim Horton 2014-03-21 15:34:07 PDT 
Comment on attachment 227499 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227499&action=review

> Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp:38
> +#if defined(__has_include) && __has_include(<xpc/private.h>)

no need for the defined() check

> Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp:41
> +extern "C" void xpc_connection_get_audit_token(xpc_connection_t, audit_token_t*);

I think we should be doing this *outside* of the #if, not in an #else, so we get errors if the signature changes.

> Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:32
> +#include "WebProcess.h"
>  #include "WebPage.h"

this looks sorted wrong
Comment 8 Sam Weinig 2014-03-21 15:43:48 PDT 
Committed r166103: <http://trac.webkit.org/changeset/166103>