Bug 130517 - [GTK] Suppress errors about using gdk_threads_enter gdk_threads_leave
Summary: [GTK] Suppress errors about using gdk_threads_enter gdk_threads_leave
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-20 09:49 PDT by Martin Robinson
Modified: 2014-03-20 20:01 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.29 KB, patch)
2014-03-20 09:59 PDT, Martin Robinson 		svillar: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2014-03-20 09:49:40 PDT 
These errors are false positives, since we actually need to use the APIs.
Comment 1 Martin Robinson 2014-03-20 09:59:07 PDT 
Created attachment 227298 [details]
Patch
Comment 2 WebKit Commit Bot 2014-03-20 10:01:30 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Alberto Garcia 2014-03-20 11:34:50 PDT 
(In reply to comment #1)
> Created an attachment (id=227298) [details]
> Patch

lgtm, thanks!
Comment 4 Sergio Villar Senin 2014-03-20 11:43:51 PDT 
Comment on attachment 227298 [details]
Patch

r=me. Consider adding a FIXME to the comments mentioning that all the deprecation warnings will be suppresed.
Comment 5 Sergio Villar Senin 2014-03-20 11:44:18 PDT 
Comment on attachment 227298 [details]
Patch

errrr
Comment 6 Martin Robinson 2014-03-20 20:01:25 PDT 
Committed r166035: <http://trac.webkit.org/changeset/166035>