Bug 130494 - EmptyUnique strings are Identifiers/Atomic
Summary: EmptyUnique strings are Identifiers/Atomic
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
Depends on:
Reported: 2014-03-19 19:54 PDT by Gavin Barraclough
Modified: 2014-03-19 23:22 PDT (History)
3 users (show)

See Also:

Fix (9.72 KB, patch)
2014-03-19 20:11 PDT, Gavin Barraclough
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2014-03-19 19:54:04 PDT
EmptyUnique strings should set the Identifier/Atomic flag.
Comment 1 Gavin Barraclough 2014-03-19 20:11:44 PDT
Created attachment 227249 [details]
Comment 2 Geoffrey Garen 2014-03-19 20:33:27 PDT
Comment on attachment 227249 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=227249&action=review


> Source/JavaScriptCore/ChangeLog:10
> +        This fixes a unreproducible bug we believe exists in Identifier handling.


> Source/JavaScriptCore/ChangeLog:13
> +        through the main Identifier constructor, the Identifier flags is not set


> Source/JavaScriptCore/ChangeLog:20
> +        by-id (cachable) accesses to PrivateNames the we can end up passing an

s/the we/we/

> Source/WTF/wtf/text/StringStatics.cpp:63
> +    } while (!(s_nextHashAndFlagsForEmptyUnique >> s_flagCount));

You could do away with this loop by just OR'ing a 1 into the top bit. Top bits never get used, anyway.
Comment 3 Gavin Barraclough 2014-03-19 23:22:21 PDT
Transmitting file data ........
Committed revision 165946.