EmptyUnique strings should set the Identifier/Atomic flag.
Created attachment 227249 [details] Fix
Comment on attachment 227249 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=227249&action=review r=me > Source/JavaScriptCore/ChangeLog:10 > + This fixes a unreproducible bug we believe exists in Identifier handling. "an" > Source/JavaScriptCore/ChangeLog:13 > + through the main Identifier constructor, the Identifier flags is not set "flag" > Source/JavaScriptCore/ChangeLog:20 > + by-id (cachable) accesses to PrivateNames the we can end up passing an s/the we/we/ > Source/WTF/wtf/text/StringStatics.cpp:63 > + } while (!(s_nextHashAndFlagsForEmptyUnique >> s_flagCount)); You could do away with this loop by just OR'ing a 1 into the top bit. Top bits never get used, anyway.
Transmitting file data ........ Committed revision 165946.