RESOLVED FIXED 130494
EmptyUnique strings are Identifiers/Atomic 
https://bugs.webkit.org/show_bug.cgi?id=130494
Summary EmptyUnique strings are Identifiers/Atomic
Gavin Barraclough
Reported 2014-03-19 19:54:04 PDT
EmptyUnique strings should set the Identifier/Atomic flag.
Attachments
Fix (9.72 KB, patch)
2014-03-19 20:11 PDT, Gavin Barraclough 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2014-03-19 20:11:44 PDT
Created attachment 227249 [details] Fix
Geoffrey Garen
Comment 2 2014-03-19 20:33:27 PDT
Comment on attachment 227249 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=227249&action=review r=me > Source/JavaScriptCore/ChangeLog:10 > + This fixes a unreproducible bug we believe exists in Identifier handling. "an" > Source/JavaScriptCore/ChangeLog:13 > + through the main Identifier constructor, the Identifier flags is not set "flag" > Source/JavaScriptCore/ChangeLog:20 > + by-id (cachable) accesses to PrivateNames the we can end up passing an s/the we/we/ > Source/WTF/wtf/text/StringStatics.cpp:63 > + } while (!(s_nextHashAndFlagsForEmptyUnique >> s_flagCount)); You could do away with this loop by just OR'ing a 1 into the top bit. Top bits never get used, anyway.
Gavin Barraclough
Comment 3 2014-03-19 23:22:21 PDT
Transmitting file data ........ Committed revision 165946.
Note You need to log in before you can comment on or make changes to this bug.