Bug 130490 – media/video-remote-control-playpause.html frequently fails on the bots

• Status: REOPENED
• Component: Media

[Eric Carlson]

This test passes on my machines with --iterations=10000 but frequently fails on the bots.

[Eric Carlson]

Marked as flakey in https://trac.webkit.org/r165937 while I try to reproduce it.

[Andy Estes]

Looks like this test is no longer marked flaky in TestExpectations, but the test still flakily crashes and times out according to https://results.webkit.org/?suite=layout-tests&test=media%2Fvideo-remote-control-playpause.html

[Radar WebKit Bug Importer]

<rdar://problem/114097537>

[Andy Estes]

Pull request: https://github.com/WebKit/WebKit/pull/16840

[EWS]

Committed 267046@main (662d6eb482e6): <https://commits.webkit.org/267046@main>

Reviewed commits have been landed. Closing PR #16840 and removing active labels.

[Andy Estes]

I don't know what causes the test to time out, but I think I understand why it crashes sometimes. In VideoFullscreenManager::removeContext, videoElement can be null here:
```
    RefPtr<HTMLVideoElement> videoElement = model->videoElement();
    ...
    m_videoElements.remove(*videoElement);
```

[Andy Estes]

Reopening