I've found it useful to hide the confidence interval delta from the results table sometimes, for example on copying data, or for clearer look. This patch introduces a new button for it on the local results page.
Created attachment 227227 [details] Patch
Comment on attachment 227227 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227227&action=review > PerformanceTests/resources/results-template.html:600 > + function clearConfidenceIntervalDeltaBit() { > + $('#confidenceIntervalDelta').children().addClass('checked'); > + $('#confidenceIntervalDelta').children().last().removeClass('checked'); > + } I don't think it makes sense to reset this switch. We should construct the view preserving this value. > PerformanceTests/resources/results-template.html:619 > + hideConfidenceIntervalDelta = checkedElement.textContent == 'Hide'; Missing var.
Created attachment 227297 [details] Patch (In reply to comment #2) > I don't think it makes sense to reset this switch. We should construct the view preserving this value. I was thinking on the best behavior. It makes sense to preserve it too. I modified the patch.
Comment on attachment 227297 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227297&action=review > PerformanceTests/resources/results-template.html:395 > + var hideConfidenceIntervalDelta = $('#confidenceIntervalDelta').children().last().hasClass('checked'); > + See what we're doing for '#time-memory'. 586 $('#time-memory').bind('change', function (event, checkedElement) { 587 shouldIgnoreMemory = checkedElement.textContent == 'Time'; 588 createTable(metrics, runs, shouldIgnoreMemory, referenceIndex); 589 });
Created attachment 227365 [details] Patch I modified it as we've got it for the memory-switcher.
Comment on attachment 227365 [details] Patch Clearing flags on attachment: 227365 Committed r166038: <http://trac.webkit.org/changeset/166038>
All reviewed patches have been landed. Closing bug.