Bug 130481 - Win64 needs some love
Summary: Win64 needs some love
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 8
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-19 15:02 PDT by Alex Christensen
Modified: 2014-03-20 13:49 PDT (History)
2 users (show)

See Also:

Attachments
Patch (10.31 KB, patch)
2014-03-19 15:04 PDT, Alex Christensen 		bfulgham: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2014-03-19 15:02:30 PDT 
Just some maintenance.  I noticed the AppleWin port isn't building the WebInspectorUI project, but I didn't fix it in case there's a reason for that.
Comment 1 Alex Christensen 2014-03-19 15:04:29 PDT 
Created attachment 227223 [details]
Patch
Comment 2 Brent Fulgham 2014-03-20 13:39:55 PDT 
Comment on attachment 227223 [details]
Patch

Looks good. We should building WebInspectorUI, so go ahead and add it in the future.
Comment 3 WebKit Commit Bot 2014-03-20 13:43:08 PDT 
Comment on attachment 227223 [details]
Patch

Rejecting attachment 227223 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 build commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebKitTestRunner.build/Release/WebKitTestRunner.build/Objects-normal/x86_64/TestController.o TestController.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebKitTestRunner.build/Release/WebKitTestRunner.build/Objects-normal/x86_64/PlatformWebViewMac.o mac/PlatformWebViewMac.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
(2 failures)

Full output: http://webkit-queues.appspot.com/results/5284991248367616
Comment 4 Alex Christensen 2014-03-20 13:49:49 PDT 
http://trac.webkit.org/changeset/165994