Bug 130469 - Build fails when 3d rendering is disabled
Summary: Build fails when 3d rendering is disabled
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-19 10:43 PDT by Tomeu Vizoso
Modified: 2022-03-01 01:41 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.99 KB, patch)
2014-03-19 10:45 PDT, Tomeu Vizoso 		bfulgham: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomeu Vizoso 2014-03-19 10:43:46 PDT 
Because of missing USE(3D_GRAPHICS) guards.
Comment 1 Tomeu Vizoso 2014-03-19 10:45:33 PDT 
Created attachment 227197 [details]
Patch
Comment 2 Brent Fulgham 2016-03-14 11:13:14 PDT 
Comment on attachment 227197 [details]
Patch

This patch seems reasonable. However, it's a few years out of date. Can this be updated so that it applies and works with current sources?
Comment 3 Adrian Perez 2022-03-01 01:41:33 PST 
The files referenced by the patch are long gone, and IIUC the
replacement is GraphicsContextGL.h and friends, which do have
guards covering the whole file, for example ENABLE(WEBGL) for
GraphicsContextGL.h