Bug 130466 - [GTK][CMake] CMake build fails to link TestNetscapePlugIn
Summary: [GTK][CMake] CMake build fails to link TestNetscapePlugIn
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 130462 130465 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-03-19 10:24 PDT by Tomeu Vizoso
Modified: 2016-01-03 17:15 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.05 KB, patch)
2014-03-19 10:30 PDT, Tomeu Vizoso 		no flags Details | Formatted Diff | Diff
Patch (2.07 KB, patch)
2014-03-19 10:50 PDT, Tomeu Vizoso 		mcatanzaro: review-
mcatanzaro: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomeu Vizoso 2014-03-19 10:24:23 PDT 
Because of missing -lX11
Comment 1 Tomeu Vizoso 2014-03-19 10:27:10 PDT 
*** Bug 130462 has been marked as a duplicate of this bug. ***
Comment 2 Tomeu Vizoso 2014-03-19 10:27:25 PDT 
*** Bug 130465 has been marked as a duplicate of this bug. ***
Comment 3 Tomeu Vizoso 2014-03-19 10:30:02 PDT 
Created attachment 227192 [details]
Patch
Comment 4 WebKit Commit Bot 2014-03-19 10:32:58 PDT 
Attachment 227192 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Tomeu Vizoso 2014-03-19 10:50:57 PDT 
Created attachment 227199 [details]
Patch
Comment 6 Martin Robinson 2014-03-22 20:45:42 PDT 
Comment on attachment 227199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227199&action=review

> Source/cmake/OptionsGTK.cmake:169
> +# FIXME: This is needed just for TestNetscapePlugIn, which calls X directly.
> +find_package(X11 REQUIRED)
> +

Why is this necessary? CMake already looks for X11 libraries by default.
Comment 7 Michael Catanzaro 2016-01-03 17:15:38 PST 
Comment on attachment 227199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227199&action=review

Sorry this went unreviewed for so long. :(

>> Source/cmake/OptionsGTK.cmake:169
>> +
> 
> Why is this necessary? CMake already looks for X11 libraries by default.

We wound up adding this earlier this year, for compatibility with newer CMake, but guarded by if (ENABLE_X11_TARGET). Anyway, it doesn't need to be added anymore, because we already have done so....

> Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:41
> +    ${X11_X11_LIB}

And DRT is no longer used by the GTK+ port, so I think this patch is obsolete.