Bug 130466 – [GTK][CMake] CMake build fails to link TestNetscapePlugIn

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKitGTK

[Tomeu Vizoso]

Because of missing -lX11

[Tomeu Vizoso]

*** Bug 130462 has been marked as a duplicate of this bug. ***

[Tomeu Vizoso]

*** Bug 130465 has been marked as a duplicate of this bug. ***

[Tomeu Vizoso]

Created attachment 227192 [details]
Patch

[WebKit Commit Bot]

Attachment 227192 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tomeu Vizoso]

Created attachment 227199 [details]
Patch

[Martin Robinson]

Comment on attachment 227199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227199&action=review

> Source/cmake/OptionsGTK.cmake:169
> +# FIXME: This is needed just for TestNetscapePlugIn, which calls X directly.
> +find_package(X11 REQUIRED)
> +

Why is this necessary? CMake already looks for X11 libraries by default.

[Michael Catanzaro]

Comment on attachment 227199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227199&action=review

Sorry this went unreviewed for so long. :(

>> Source/cmake/OptionsGTK.cmake:169
>> +
> 
> Why is this necessary? CMake already looks for X11 libraries by default.

We wound up adding this earlier this year, for compatibility with newer CMake, but guarded by if (ENABLE_X11_TARGET). Anyway, it doesn't need to be added anymore, because we already have done so....

> Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:41
> +    ${X11_X11_LIB}

And DRT is no longer used by the GTK+ port, so I think this patch is obsolete.