Bug 130455 – Update some references for MathML pixels tests

• Status: RESOLVED
• Resolution: FIXED
• Component: MathML

[Frédéric Wang (:fredw)]

We should update the txt & png references for the following tests:

- mathml/presentation/mspace-children.html
- mathml/presentation/mo-stretch.html
- mathml/presentation/mo.xhtml
- mathml/presentation/roots.xhtml
- mathml/presentation/row.xhtml

The last three are currently marked FAIL in the main TestExpectation. The two first are marked FAIL for some platforms.

[Frédéric Wang (:fredw)]

*** Bug 127482 has been marked as a duplicate of this bug. ***

[Frédéric Wang (:fredw)]

Created attachment 227187 [details]
Patch V1 (updating TestExpectations)

Here are the failing tests whose ref must be updated.

[Frédéric Wang (:fredw)]

So I just tried on GTK+:

LayoutTests/mathml/presentation/row.xhtml

- I'm not sure what is tested by the "x+1" but we have other tests for token elements.
- The test used green <div> inside <mtext> which is invalid (see bug 124128). They should be replaced with <mspace> or inline-block span. 
- The stretchy operators are already tested in mo-stretch and they are many other reftests for operator stretching.

=> So actually I think we can remove the whole test?

LayoutTests/mathml/presentation/roots.xhtml

- only some small spacing changes
- I already rewrote the last "don't wrap" test as a reftest LayoutTests/mathml/presentation/bug95015.html so it can be removed.

LayoutTests/mathml/presentation/mo.xhtml

- one test uses the invalid <div> in <mtext> (see above)
- it's not clear to me what the other tests verify, but I believe we already test mfrac/mo/mathsize elsewhere...

=> Should we remove that test?

For the other platforms, I believe it is safe to just update the references of mathml/presentation/mspace-children.html and mathml/presentation/mo-stretch.html.

[Frédéric Wang (:fredw)]

Created attachment 227194 [details]
Patch V2 (Updating TestExpectations and trying to fix markup errors in tests)

Here is an updated patch, that tries to fix some errors in the tests.

It seems that setting background color on <mo> (but not on other token elements) is broken so I'll open a separate bug for that and write a reftest.

[Frédéric Wang (:fredw)]

Created attachment 227257 [details]
Patch V3

OK, this patch removes the mo.xhtml and row.xhtml tests since features seem to be already tested elsewhere. I updated the references for GTK and tried to do so for EFL (but for some reason the png screenshots are empty for me). Could someone please use this patch to

- update the png & txt references for roots.xhtml/mspace-children.html/mo-stretch.html on Windows?
- check the txt references and update the png images for roots.xhtml/mspace-children.html/mo-stretch.html on EFL?
- update the png references for roots.xhtml/mspace-children.html/mo-stretch.html on Mac?

Thanks,

[Frédéric Wang (:fredw)]

Created attachment 227259 [details]
Patch V4

I forgot the --binary flag...

[Build Bot]

Comment on attachment 227259 [details]
Patch V4

Attachment 227259 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5848997226872832

New failing tests:
mathml/presentation/roots.xhtml

[Build Bot]

Created attachment 227261 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Frédéric Wang (:fredw)]

Created attachment 227263 [details]
Patch V5

Update the roots-expected.txt on Mac...

[chris fleizach]

(In reply to comment #9)
> Created an attachment (id=227263) [details]
> Patch V5
> 
> Update the roots-expected.txt on Mac...

Is this patch ready for review? or are you still waiting for image results for various platforms ( i see some empty images in this patch)

[Frédéric Wang (:fredw)]

(In reply to comment #10)
> Is this patch ready for review? or are you still waiting for image results for various platforms ( i see some empty images in this patch)

I'm waiting txt/images results mentioned in comment 5, but can not generate them myself. And the EWS bots only run the tests on mac IIUC.

[Frédéric Wang (:fredw)]

Should I wait that people update the references?

Or should I commit the changes and update the references afterwards, once I get the bot results?

[chris fleizach]

(In reply to comment #12)
> Should I wait that people update the references?
> 
> Or should I commit the changes and update the references afterwards, once I get the bot results?

You should probably commit and then try to be vigilant in getting results quickly. I don't think we're going to get anyone to provide those results prior

[Frédéric Wang (:fredw)]

Committed r166059: <http://trac.webkit.org/changeset/166059>

[Frédéric Wang (:fredw)]

I think the Mac and EFL will pass. At the moment the Windows and EFL tests are crashing so I won't be able to get the MathML results until it is fixed.