RESOLVED FIXED 130437
Filter out editable services from image menu for non-contenteditable images 
https://bugs.webkit.org/show_bug.cgi?id=130437
Summary Filter out editable services from image menu for non-contenteditable images
Brady Eidson
Reported 2014-03-18 17:41:05 PDT
Filter out editable services from image menu for non-contenteditable images In radar <rdar://problem/16319645>
Attachments
Patch v1 (10.70 KB, patch)
2014-03-19 09:40 PDT, Brady Eidson 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2014-03-19 09:40:55 PDT
Created attachment 227188 [details] Patch v1
Tim Horton
Comment 2 2014-03-19 12:18:47 PDT
Comment on attachment 227188 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=227188&action=review > Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:55 > +- (instancetype)initWithImage:(NSImage *)image includeEditorServices:(BOOL)includeEditorServices menuClient:(WebContextMenuClient*)menuClient Is the list of things to exclude likely to expand? If so, we might want to consider doing something different here.
Brady Eidson
Comment 3 2014-03-19 12:26:15 PDT
(In reply to comment #2) > (From update of attachment 227188 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=227188&action=review > > > Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:55 > > +- (instancetype)initWithImage:(NSImage *)image includeEditorServices:(BOOL)includeEditorServices menuClient:(WebContextMenuClient*)menuClient > > Is the list of things to exclude likely to expand? If so, we might want to consider doing something different here. I don't predict the list expanding. That said, I'm comfortable with the principal of doing it this way for the one known thing, then if a second thing comes up later we can reassess.
Tim Horton
Comment 4 2014-03-19 12:53:29 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 227188 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=227188&action=review > > > > > Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:55 > > > +- (instancetype)initWithImage:(NSImage *)image includeEditorServices:(BOOL)includeEditorServices menuClient:(WebContextMenuClient*)menuClient > > > > Is the list of things to exclude likely to expand? If so, we might want to consider doing something different here. > > I don't predict the list expanding. > > That said, I'm comfortable with the principal of doing it this way for the one known thing, then if a second thing comes up later we can reassess. Yeah, that's fine.
Brady Eidson
Comment 5 2014-03-19 13:13:13 PDT
https://trac.webkit.org/changeset/165911
Note You need to log in before you can comment on or make changes to this bug.